Re: [PATCH mptcp-next v11 0/8] add helpers and vars in mptcp_lib.sh, part 3

[Matthieu Baerts <matttbe@kernel.org>]

Hi Geliang,

On 03/03/2024 12:52, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
> 
> v11:
>  - fix the shellcheck error in v10
> 
> v10:
>  - split two more patches (#4 and #5) from #6 and #7
>  - update commit logs
> 
> v9:
>  - move print_larger_title from patch 5 to patch 2
>  - move MPTCP_LIB_TEST_FORMAT to a more suitable location in patch 4 and
>    patch 5
> 
> v8:
>  - address every comment from Matt in v7.

If you don't mind, please add a short changelog per individual patch.
Without that, it is quite hard to understand what you modified, if there
was something you didn't do on purpose or by accident, which patch has
moved where, etc. Without that, I end up re-reviewing the whole series
like it was a new one.

Apart from that, I think we are almost there. Two details on the two
first patches, then it looks like we might print 'OK', then 'FAIL' in
patch 4. And we might print 'OK', then some 'WARN' without '\n' at the
end in patch 8.


One important question: did you check the output when you force issues?
Just to make sure they are presented correctly, and mainly if we still
catch them!

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.