From: Heinrich Schuchardt <xypron.glpk@gmx.de>
To: u-boot@lists.denx.de
Subject: [PATCH 1/1] efi_loader remove __packed from struct efi_configuration_table
Date: Tue, 7 Jan 2020 07:37:45 +0100 [thread overview]
Message-ID: <88cb09cb-5202-e021-a292-05937a00a793@gmx.de> (raw)
In-Reply-To: <20191228145456.33863-1-xypron.glpk@gmx.de>
On 12/28/19 3:54 PM, Heinrich Schuchardt wrote:
> struct efi_configuration_table is naturally packed. There is no need for a
> __packed attribute. Hence remove it.
This holds true only on 64bit systems as we defined efi_guid_t to be
8-byte aligned. Instead adjust guidcpy to accept void *. See
https://lists.denx.de/pipermail/u-boot/2020-January/395409.html
[PATCH v5 1/1] efi_loader: Add guidcpy function
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
> include/efi_api.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/efi_api.h b/include/efi_api.h
> index 22396172e1..a3ff140ac9 100644
> --- a/include/efi_api.h
> +++ b/include/efi_api.h
> @@ -322,7 +322,7 @@ struct efi_runtime_services {
> struct efi_configuration_table {
> efi_guid_t guid;
> void *table;
> -} __packed;
> +};
>
> #define EFI_SYSTEM_TABLE_SIGNATURE ((u64)0x5453595320494249ULL)
>
> --
> 2.24.1
>
>
prev parent reply other threads:[~2020-01-07 6:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-28 14:54 [PATCH 1/1] efi_loader remove __packed from struct efi_configuration_table Heinrich Schuchardt
2020-01-07 6:37 ` Heinrich Schuchardt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88cb09cb-5202-e021-a292-05937a00a793@gmx.de \
--to=xypron.glpk@gmx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.