Re: [PATCH bpf-next] selftests/bpf: Fix RELEASE build failure with gcc14

[Yonghong Song <yonghong.song@linux.dev>]

On 6/17/25 10:24 AM, Alexei Starovoitov wrote:
> On Mon, Jun 16, 2025 at 9:50 PM Yonghong Song <yonghong.song@linux.dev> wrote:
>> With gcc14, when building with RELEASE=1, I hit four below compilation
>> failure:
>>
>> Error 1:
>>    In file included from test_loader.c:6:
>>    test_loader.c: In function ‘run_subtest’: test_progs.h:194:17:
>>        error: ‘retval’ may be used uninitialized in this function
>>     [-Werror=maybe-uninitialized]
>>      194 |                 fprintf(stdout, ##format);           \
>>          |                 ^~~~~~~
>>    test_loader.c:958:13: note: ‘retval’ was declared here
>>      958 |         int retval, err, i;
>>          |             ^~~~~~
>>
>>    The uninitialized var 'retval' actaully could cause incorrect result.
> actually
>
>> Error 2:
>>    In function ‘test_fd_array_cnt’:
>>    prog_tests/fd_array.c:71:14: error: ‘btf_id’ may be used uninitialized in this
>>        function [-Werror=maybe-uninitialized]
>>       71 |         fd = bpf_btf_get_fd_by_id(id);
>>          |              ^~~~~~~~~~~~~~~~~~~~~~~~
>>    prog_tests/fd_array.c:302:15: note: ‘btf_id’ was declared here
>>      302 |         __u32 btf_id;
>>          |               ^~~~~~
>>
>>    Changing ASSERT_GE to ASSERT_EQ can fix the compilation error. Otherwise,
>>    there is no functionality change.
>>
>> Error 3:
>>    prog_tests/tailcalls.c: In function ‘test_tailcall_hierarchy_count’:
>>    prog_tests/tailcalls.c:1402:23: error: ‘fentry_data_fd’ may be used uninitialized
>>        in this function [-Werror=maybe-uninitialized]
>>       1402 |                 err = bpf_map_lookup_elem(fentry_data_fd, &i, &val);
>>            |                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>
>>    The code is correct. The change intends to slient gcc errors.
> to silence.
>
> Fixed the typos while applying.
> Pls use spell check.

Sorry about typo's. Will pay attention to spell check for later patches.