From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A69C9C54E5D for ; Mon, 18 Mar 2024 21:29:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lSFRThuzFltj9C+21xWzyhW8ZNTMPPoZ2nO/faNjGWs=; b=bSdn9HNbv7iVtz 0FNCdMVTBTe1DvRgOLKI60LUpllbatJZLqrzXyZzTcXRVI044L4ZuXF8rryyJIRUrmUBOnhQ01N2q T6r9n4Uicilu7AvjbRUQTYrAeXwneTgB+HiShtgl18KTAQRFLsHf517BMB8f6Hp9gFrjEMvkgICD/ V+mnwN+LIUzmLLzmSONmodVeObbzBg+gT7kjMbbZXLTDYL3vKlkNAMxKjm5m/81LEHkndViHsr+Q6 RSJI4goKigN4NFVWA7hL5jaXMUgslTRsSv5gum1pcCi+KJ8Bzv+atCf/8fbCSHvLjMChp+Jv+Tfny MTh4jRY9kpTK2jH3kv+g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmKY6-0000000ADYE-2sKo; Mon, 18 Mar 2024 21:29:38 +0000 Received: from mail-il1-x131.google.com ([2607:f8b0:4864:20::131]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmKY3-0000000ADVq-0xd7 for linux-riscv@lists.infradead.org; Mon, 18 Mar 2024 21:29:37 +0000 Received: by mail-il1-x131.google.com with SMTP id e9e14a558f8ab-3684320a751so2157235ab.1 for ; Mon, 18 Mar 2024 14:29:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1710797373; x=1711402173; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/Nul1eVuq4XLe3SGFf2DVNn6S2hK2sqq4oKFGkGjGXg=; b=J4HmqOBK2A+6Nd2ojvA3QwnYRYTiYlK8n8ozJWMrM90iJs80YtOuFfuWNBaRawOVvx 7XeEo2riBRMz+/vNRCgdTCn8zn9JF8iXBrwZRP47UvTkMFU/CDuOe2kPSzf9CnszQi8v GpMl7y1a2oafnmZIb77OM8UBQm9Yjcnkvt87jodif2uJVW1dcs5M56sr1kTjkntttJNf OS5hpH47TAAvrTAjq5QEUN0Xo49ndYEYK5CdT97nXnCcQhyCa9BclBEtxzhnqZ4jvt9g w1pqHGjJcq26g2tUCt3WgmTm0g1Qc4R8lZ/nGZm/H8nzBCJ0W8R7IHCJR5HUqqIhRypJ QpYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710797373; x=1711402173; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/Nul1eVuq4XLe3SGFf2DVNn6S2hK2sqq4oKFGkGjGXg=; b=Hu9JVRIhInTMLZ9CvppwLRUxzTYvz2tKv4oqKZ+YvTbY/WvlXy5ceNFiUVcBNAjsxe 9PqQdpfL1LqOx5UY3j9uOq46XuD5qqGtRrOoCCmNMPSt0Q4wlhPKLp41gK+BQ8qRZUdq 2zF2nN+Kd4cyulZ4bddU0w2zyHypfLuKGcpCx54cmuYbdnMraB7PwxuH0Ojqgeaj9zVq 90/KUOfCzP3F+rjWt2zEJzBe5BKAtlqZVY/jDXv2PyCa9cg2dp1j8MVb4eBzawQPsL5D mtcX05m/RhFjxGXT41F7+z5CJcL2C7lmLi38hbkiB7DLZM3Q1/shEy4lyqrotXVdhU7r 4V5w== X-Forwarded-Encrypted: i=1; AJvYcCWuhyCNXww/iwkKRSWJ0ug4IwRb2bWqOtGyngwz5JY3BxZDcvali3lphKwXT2rFjKn8VjxyQ5yzx79y9ydv5Pw7kEGA2M4B5Yl1mwxnQAL5 X-Gm-Message-State: AOJu0YwxkpYY5nJBBz6mCt81hgfhrhYLRnDSVAZDZoAUCyIM07MPBDsL Mr5sHA/wqmmGPEDHYIubzcANhpsboLOb00jN8khxpgGBlH7zoWdOlM6pplJKo/k= X-Google-Smtp-Source: AGHT+IGplRx/3NjrYT/brJF88QRJLUV/wi8Qy9KFuvMjBRp+xMbCOC5rIkYwtdBM4rJ6IEL040jsVA== X-Received: by 2002:a05:6e02:1064:b0:366:8c58:42ea with SMTP id q4-20020a056e02106400b003668c5842eamr887284ilj.11.1710797372753; Mon, 18 Mar 2024 14:29:32 -0700 (PDT) Received: from [100.64.0.1] ([136.226.86.189]) by smtp.gmail.com with ESMTPSA id l13-20020a056e0205cd00b00366164573dfsm2512024ils.63.2024.03.18.14.29.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Mar 2024 14:29:32 -0700 (PDT) Message-ID: <88de4a1a-047e-4be9-b5b0-3e53434dc022@sifive.com> Date: Mon, 18 Mar 2024 16:29:30 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] riscv: Define TASK_SIZE_MAX for __access_ok() Content-Language: en-US To: Alexandre Ghiti Cc: Palmer Dabbelt , linux-riscv@lists.infradead.org, Albert Ou , Andrew Morton , Charlie Jenkins , Guo Ren , Jisheng Zhang , Kemeng Shi , "Matthew Wilcox (Oracle)" , "Mike Rapoport (IBM)" , Paul Walmsley , Xiao Wang , Yangyu Chen , linux-kernel@vger.kernel.org References: <20240313180010.295747-1-samuel.holland@sifive.com> From: Samuel Holland In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240318_142935_486647_0BAF8203 X-CRM114-Status: GOOD ( 23.52 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org SGkgQWxleCwKCk9uIDIwMjQtMDMtMTggMzo1MCBQTSwgQWxleGFuZHJlIEdoaXRpIHdyb3RlOgo+ IE9uIFdlZCwgTWFyIDEzLCAyMDI0IGF0IDc6MDDigK9QTSBTYW11ZWwgSG9sbGFuZAo+IDxzYW11 ZWwuaG9sbGFuZEBzaWZpdmUuY29tPiB3cm90ZToKPj4KPj4gVEFTS19TSVpFX01BWCBzaG91bGQg YmUgc2V0IHRvIHRoZSBsYXJnZXN0IHVzZXJzcGFjZSBhZGRyZXNzIHVuZGVyIGFueQo+PiBydW50 aW1lIGNvbmZpZ3VyYXRpb24uIFRoaXMgb3B0aW1pemVzIHRoZSBjaGVjayBpbiBfX2FjY2Vzc19v aygpLCB3aGljaAo+PiBubyBsb25nZXIgbmVlZHMgdG8gY29tcHV0ZSB0aGUgY3VycmVudCB2YWx1 ZSBvZiBUQVNLX1NJWkUuIEl0IGlzIHN0aWxsCj4+IHNhZmUgYmVjYXVzZSBhZGRyZXNzZXMgYmV0 d2VlbiBUQVNLX1NJWkUgYW5kIFRBU0tfU0laRV9NQVggYXJlIGludmFsaWQKPj4gYXQgdGhlIGhh cmR3YXJlIGxldmVsLgo+Pgo+PiBUaGlzIHJlbW92ZXMgYWJvdXQgaGFsZiBvZiB0aGUgcmVmZXJl bmNlcyB0byBwZ3RhYmxlX2xbNDVdX2VuYWJsZWQuCj4+Cj4+IFNpZ25lZC1vZmYtYnk6IFNhbXVl bCBIb2xsYW5kIDxzYW11ZWwuaG9sbGFuZEBzaWZpdmUuY29tPgo+PiAtLS0KPj4KPj4gIGFyY2gv cmlzY3YvaW5jbHVkZS9hc20vcGd0YWJsZS02NC5oIHwgMSArCj4+ICBhcmNoL3Jpc2N2L2luY2x1 ZGUvYXNtL3BndGFibGUuaCAgICB8IDEgKwo+PiAgMiBmaWxlcyBjaGFuZ2VkLCAyIGluc2VydGlv bnMoKykKPj4KPj4gZGlmZiAtLWdpdCBhL2FyY2gvcmlzY3YvaW5jbHVkZS9hc20vcGd0YWJsZS02 NC5oIGIvYXJjaC9yaXNjdi9pbmNsdWRlL2FzbS9wZ3RhYmxlLTY0LmgKPj4gaW5kZXggYjk5YmQ2 NjEwN2E2Li5hNjc3ZWYzYzBmZTIgMTAwNjQ0Cj4+IC0tLSBhL2FyY2gvcmlzY3YvaW5jbHVkZS9h c20vcGd0YWJsZS02NC5oCj4+ICsrKyBiL2FyY2gvcmlzY3YvaW5jbHVkZS9hc20vcGd0YWJsZS02 NC5oCj4+IEBAIC0xNyw2ICsxNyw3IEBAIGV4dGVybiBib29sIHBndGFibGVfbDVfZW5hYmxlZDsK Pj4gICNkZWZpbmUgUEdESVJfU0hJRlRfTDQgIDM5Cj4+ICAjZGVmaW5lIFBHRElSX1NISUZUX0w1 ICA0OAo+PiAgI2RlZmluZSBQR0RJUl9TSVpFX0wzICAgKF9BQygxLCBVTCkgPDwgUEdESVJfU0hJ RlRfTDMpCj4+ICsjZGVmaW5lIFBHRElSX1NJWkVfTDUgICAoX0FDKDEsIFVMKSA8PCBQR0RJUl9T SElGVF9MNSkKPj4KPj4gICNkZWZpbmUgUEdESVJfU0hJRlQgICAgIChwZ3RhYmxlX2w1X2VuYWJs ZWQgPyBQR0RJUl9TSElGVF9MNSA6IFwKPj4gICAgICAgICAgICAgICAgIChwZ3RhYmxlX2w0X2Vu YWJsZWQgPyBQR0RJUl9TSElGVF9MNCA6IFBHRElSX1NISUZUX0wzKSkKPj4gZGlmZiAtLWdpdCBh L2FyY2gvcmlzY3YvaW5jbHVkZS9hc20vcGd0YWJsZS5oIGIvYXJjaC9yaXNjdi9pbmNsdWRlL2Fz bS9wZ3RhYmxlLmgKPj4gaW5kZXggNjA2NjgyMmU3Mzk2Li4yMDMyZjhhYzVmYzUgMTAwNjQ0Cj4+ IC0tLSBhL2FyY2gvcmlzY3YvaW5jbHVkZS9hc20vcGd0YWJsZS5oCj4+ICsrKyBiL2FyY2gvcmlz Y3YvaW5jbHVkZS9hc20vcGd0YWJsZS5oCj4+IEBAIC04NjcsNiArODY3LDcgQEAgc3RhdGljIGlu bGluZSBwdGVfdCBwdGVfc3dwX2NsZWFyX2V4Y2x1c2l2ZShwdGVfdCBwdGUpCj4+ICAjaWZkZWYg Q09ORklHXzY0QklUCj4+ICAjZGVmaW5lIFRBU0tfU0laRV82NCAgIChQR0RJUl9TSVpFICogUFRS U19QRVJfUEdEIC8gMikKPj4gICNkZWZpbmUgVEFTS19TSVpFX01JTiAgKFBHRElSX1NJWkVfTDMg KiBQVFJTX1BFUl9QR0QgLyAyKQo+PiArI2RlZmluZSBUQVNLX1NJWkVfTUFYICAoUEdESVJfU0la RV9MNSAqIFBUUlNfUEVSX1BHRCAvIDIpCj4+Cj4+ICAjaWZkZWYgQ09ORklHX0NPTVBBVAo+PiAg I2RlZmluZSBUQVNLX1NJWkVfMzIgICAoX0FDKDB4ODAwMDAwMDAsIFVMKSkKPj4gLS0KPj4gMi40 My4xCj4+Cj4gCj4gSSB0aGluayB5b3UgYWxzbyBuZWVkIHRvIGNoYW5nZSB0aGUgY2hlY2sgaW4g aGFuZGxlX3BhZ2VfZmF1bHQoKSBieQo+IHVzaW5nIFRBU0tfU0laRV9NQVggaW5zdGVhZCBvZiBU QVNLX1NJWkUsIG90aGVyd2lzZSB0aGUgZml4dXAgY2FuJ3QKPiBoYXBwZW4gKGh0dHBzOi8vZWxp eGlyLmJvb3RsaW4uY29tL2xpbnV4L2xhdGVzdC9zb3VyY2UvYXJjaC9yaXNjdi9tbS9mYXVsdC5j I0wyNzMpLgoKSXQgaXMgbm90IG5lY2Vzc2FyeSB0byBjaGFuZ2UgdGhhdCBjaGVjayBpbiBmYXVs dC5jIHVubGVzcyB3ZSBleHBlY3QgdG8gaGFuZGxlCmV4Y2VwdGlvbnMgKG91dHNpZGUgb2YgdXNl cnNwYWNlIGFjY2VzcyByb3V0aW5lcykgZm9yIGFkZHJlc3NlcyBiZXR3ZWVuClRBU0tfU0laRSBh bmQgVEFTS19TSVpFX01BWC4gSXQgbG9va3MgbGlrZSB0aGUgY2FsbCB0byBmaXh1cF9leGNlcHRp b24oKSBbYWRkZWQKaW4gNDE2NzIxZmYwNWZkICgicmlzY3YsIG1tOiBQZXJmb3JtIEJQRiBleGhh bmRsZXIgZml4dXAgb24gcGFnZSBmYXVsdCIpXSBpcwpvbmx5IGludGVuZGVkIHRvIGNhdGNoIG51 bGwgcG9pbnRlciBkZXJlZmVyZW5jZXMuIFNvIG1ha2luZyB0aGUgY2hhbmdlIHdvdWxkbid0Cmhh dmUgYW55IGZ1bmN0aW9uYWwgaW1wYWN0LCBidXQgaXQgd291bGQgc3RpbGwgYmUgYSB2YWxpZCBv cHRpbWl6YXRpb24uCgo+IE9yIEkgd2FzIHdvbmRlcmluZyBpZiBpdCB3b3VsZCBub3QgYmUgYmV0 dGVyIHRvIGRvIGxpa2UgeDg2IGFuZCB1c2UgYW4KPiBhbHRlcm5hdGl2ZSwgaXQgd291bGQgYmUg bW9yZSBjb3JyZWN0IChldmVuIHRob3VnaCBJIGJlbGlldmUgeW91cgo+IHNvbHV0aW9uIHdvcmtz KQo+IGh0dHBzOi8vZWxpeGlyLmJvb3RsaW4uY29tL2xpbnV4L2xhdGVzdC9zb3VyY2UvYXJjaC94 ODYvaW5jbHVkZS9hc20vcGFnZV82NC5oI0w4Mi4KCldoYXQgd291bGQgYmUgdGhlIGJlbmVmaXQg b2YgdXNpbmcgYW4gYWx0ZXJuYXRpdmU/IEFueSBhY2Nlc3MgdG8gYW4gYWRkcmVzcwpiZXR3ZWVu IFRBU0tfU0laRSBhbmQgVEFTS19TSVpFX01BWCBpcyBndWFyYW50ZWVkIHRvIGdlbmVyYXRlIGEg cGFnZSBmYXVsdCwgc28KdGhlIG9ubHkgYmVuZWZpdCBJIHNlZSBpcyByZXR1cm5pbmcgLUVGQVVM VCBzbGlnaHRseSBmYXN0ZXIgYXQgdGhlIGNvc3Qgb2YKYXBwbHlpbmcgYSBmZXcgaHVuZHJlZCBh bHRlcm5hdGl2ZXMgYXQgYm9vdC4gQnV0IGl0J3MgcG9zc2libGUgSSdtIG1pc3NpbmcKc29tZXRo aW5nLgoKUmVnYXJkcywKU2FtdWVsCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KbGludXgtcmlzY3YgbWFpbGluZyBsaXN0CmxpbnV4LXJpc2N2QGxpc3Rz LmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5m by9saW51eC1yaXNjdgo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-il1-f174.google.com (mail-il1-f174.google.com [209.85.166.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99E8058233 for ; Mon, 18 Mar 2024 21:29:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710797375; cv=none; b=V/YjtzXnAHXbHTiSDwH0IDmbv+ZUKKMYca46c0NX+ltm+S6TMxPkr18gFTArj2tOPUBPeba7bGnTeLi69QGwpcl1TwakFTYTRmYhSmwlpDuf98ybMKxugBR5JNxtZTxk2TqFdnxNz9QZQLDdYS3YIGPMWLVul4jZO4+MpOGnGtY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710797375; c=relaxed/simple; bh=wa4AsEHowlTcQ7Yg5/g6MIQX/SG3V6t/gqBj8pYSItg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jOpLWVN8s9j4fz/IN0G1jDJwcICaiYgNq8RmPjxywO+19UfxJk1RoqeRyYQfhs5IwK3JAl8fmGqsva9F0QSIWF1r3YQ52iCdmHJ8fx9XIW7bM8JzrMxGpNI8ddCt3yU1JVlWhfCkdPo4ebufNS1KWYuFrpiXCChXDbWG1FOk9+k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com; spf=pass smtp.mailfrom=sifive.com; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b=mRbbR7m8; arc=none smtp.client-ip=209.85.166.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sifive.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="mRbbR7m8" Received: by mail-il1-f174.google.com with SMTP id e9e14a558f8ab-366ad40144fso5896345ab.0 for ; Mon, 18 Mar 2024 14:29:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1710797373; x=1711402173; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/Nul1eVuq4XLe3SGFf2DVNn6S2hK2sqq4oKFGkGjGXg=; b=mRbbR7m8X5JfixQi24ou2bbV4TNAeyCcRHYyskqLRwWQlu2hIMJrgWZeltOcocde8V oYTGVIrrQCr9CzaZ5+4P7hw5oyNx67zWgThX5yxPKmvlLwf8DARgGuQyKSiBHzb3snJd GTFA6eQQVAb2Affv1ujR6K1z4J95S38g9t5xHt7JCkyUymxWO04gLEYxBi7CEzitPFQY VrTmNLE7k00lL9ol2ddDeeswc8UaMiQ9KPSZ5D0ZE+UEsslVqF7wYORfJSHQjC8LXphb 2VwR0zLl+kMurAh1akG3ZiQgHP/3HyX+N3OCUwODOSH/x4ZirgLQWOHiPn1wYhc6X5It Jt1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710797373; x=1711402173; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/Nul1eVuq4XLe3SGFf2DVNn6S2hK2sqq4oKFGkGjGXg=; b=oaV7ZWN3WVq3sfZT5QAORtXB4YKhaMIHQ8Ixx7RmmXFB6AQhoB4SeVQjhYV6oMkvL9 NdVw93vYwqxwlF46X5nt6ZwAvSMe/yAPeTpfRG/Sq5NLG5xg9xAIbmDmfJ0hcZ5wG+TT JrpWALxCoGLBgXLmP37BTCFtAa3sLAgyzfij0bgzFYF5vYMr86pc3Oz3s0lqXhyArwEN VgAVXgwd+SDE0s6raVADldwSNaNT7cEn1uDYM8J4BSxdEGFfuKJw15eIsSQur55xWmzk vfNP/2KguTVekWKKgrtTTvOriD2rvjSkS5PGzD/4Hul1pK+6O8OoiN3cCKIDwyE5hHLM hqEQ== X-Forwarded-Encrypted: i=1; AJvYcCWu8kaXtAWNJynk9LDppRTCQebX5K3ZRQzpTAMkkWmX7O+rFHRy5npbbJk5XFY1mxLomMzFwY+FMx0vhs5UIAR8u+Jb3LIj6XlXlz3B X-Gm-Message-State: AOJu0YxGviObRz4PnjgcxQfPmzIShOxvSvqdgO7O83lIe6+Q0nRJhKoE XVUe5Cr0BYg2KLOSx8gzntk0U5Bt6TtF7L34y2+URCFCdHkCb4bSsSSofMeKXIU= X-Google-Smtp-Source: AGHT+IGplRx/3NjrYT/brJF88QRJLUV/wi8Qy9KFuvMjBRp+xMbCOC5rIkYwtdBM4rJ6IEL040jsVA== X-Received: by 2002:a05:6e02:1064:b0:366:8c58:42ea with SMTP id q4-20020a056e02106400b003668c5842eamr887284ilj.11.1710797372753; Mon, 18 Mar 2024 14:29:32 -0700 (PDT) Received: from [100.64.0.1] ([136.226.86.189]) by smtp.gmail.com with ESMTPSA id l13-20020a056e0205cd00b00366164573dfsm2512024ils.63.2024.03.18.14.29.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Mar 2024 14:29:32 -0700 (PDT) Message-ID: <88de4a1a-047e-4be9-b5b0-3e53434dc022@sifive.com> Date: Mon, 18 Mar 2024 16:29:30 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] riscv: Define TASK_SIZE_MAX for __access_ok() Content-Language: en-US To: Alexandre Ghiti Cc: Palmer Dabbelt , linux-riscv@lists.infradead.org, Albert Ou , Andrew Morton , Charlie Jenkins , Guo Ren , Jisheng Zhang , Kemeng Shi , "Matthew Wilcox (Oracle)" , "Mike Rapoport (IBM)" , Paul Walmsley , Xiao Wang , Yangyu Chen , linux-kernel@vger.kernel.org References: <20240313180010.295747-1-samuel.holland@sifive.com> From: Samuel Holland In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hi Alex, On 2024-03-18 3:50 PM, Alexandre Ghiti wrote: > On Wed, Mar 13, 2024 at 7:00 PM Samuel Holland > wrote: >> >> TASK_SIZE_MAX should be set to the largest userspace address under any >> runtime configuration. This optimizes the check in __access_ok(), which >> no longer needs to compute the current value of TASK_SIZE. It is still >> safe because addresses between TASK_SIZE and TASK_SIZE_MAX are invalid >> at the hardware level. >> >> This removes about half of the references to pgtable_l[45]_enabled. >> >> Signed-off-by: Samuel Holland >> --- >> >> arch/riscv/include/asm/pgtable-64.h | 1 + >> arch/riscv/include/asm/pgtable.h | 1 + >> 2 files changed, 2 insertions(+) >> >> diff --git a/arch/riscv/include/asm/pgtable-64.h b/arch/riscv/include/asm/pgtable-64.h >> index b99bd66107a6..a677ef3c0fe2 100644 >> --- a/arch/riscv/include/asm/pgtable-64.h >> +++ b/arch/riscv/include/asm/pgtable-64.h >> @@ -17,6 +17,7 @@ extern bool pgtable_l5_enabled; >> #define PGDIR_SHIFT_L4 39 >> #define PGDIR_SHIFT_L5 48 >> #define PGDIR_SIZE_L3 (_AC(1, UL) << PGDIR_SHIFT_L3) >> +#define PGDIR_SIZE_L5 (_AC(1, UL) << PGDIR_SHIFT_L5) >> >> #define PGDIR_SHIFT (pgtable_l5_enabled ? PGDIR_SHIFT_L5 : \ >> (pgtable_l4_enabled ? PGDIR_SHIFT_L4 : PGDIR_SHIFT_L3)) >> diff --git a/arch/riscv/include/asm/pgtable.h b/arch/riscv/include/asm/pgtable.h >> index 6066822e7396..2032f8ac5fc5 100644 >> --- a/arch/riscv/include/asm/pgtable.h >> +++ b/arch/riscv/include/asm/pgtable.h >> @@ -867,6 +867,7 @@ static inline pte_t pte_swp_clear_exclusive(pte_t pte) >> #ifdef CONFIG_64BIT >> #define TASK_SIZE_64 (PGDIR_SIZE * PTRS_PER_PGD / 2) >> #define TASK_SIZE_MIN (PGDIR_SIZE_L3 * PTRS_PER_PGD / 2) >> +#define TASK_SIZE_MAX (PGDIR_SIZE_L5 * PTRS_PER_PGD / 2) >> >> #ifdef CONFIG_COMPAT >> #define TASK_SIZE_32 (_AC(0x80000000, UL)) >> -- >> 2.43.1 >> > > I think you also need to change the check in handle_page_fault() by > using TASK_SIZE_MAX instead of TASK_SIZE, otherwise the fixup can't > happen (https://elixir.bootlin.com/linux/latest/source/arch/riscv/mm/fault.c#L273). It is not necessary to change that check in fault.c unless we expect to handle exceptions (outside of userspace access routines) for addresses between TASK_SIZE and TASK_SIZE_MAX. It looks like the call to fixup_exception() [added in 416721ff05fd ("riscv, mm: Perform BPF exhandler fixup on page fault")] is only intended to catch null pointer dereferences. So making the change wouldn't have any functional impact, but it would still be a valid optimization. > Or I was wondering if it would not be better to do like x86 and use an > alternative, it would be more correct (even though I believe your > solution works) > https://elixir.bootlin.com/linux/latest/source/arch/x86/include/asm/page_64.h#L82. What would be the benefit of using an alternative? Any access to an address between TASK_SIZE and TASK_SIZE_MAX is guaranteed to generate a page fault, so the only benefit I see is returning -EFAULT slightly faster at the cost of applying a few hundred alternatives at boot. But it's possible I'm missing something. Regards, Samuel