From: Marc Zyngier <maz@kernel.org>
To: linux-kernel@vger.kernel.org
Cc: Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] genirq/irqdomain: Don't try to free an interrupt that has no mapping
Date: Mon, 30 Nov 2020 11:45:56 +0000 [thread overview]
Message-ID: <88f1748b95169e79bb84f852dbea8fce@kernel.org> (raw)
In-Reply-To: <20201129135551.396777-1-maz@kernel.org>
On 2020-11-29 13:55, Marc Zyngier wrote:
> When an interrupt allocation fails for N interrupts, it is pretty
> common for the error handling code to free the same number of
> interrupts,
> no matter how many interrupts have actually been allocated.
>
> This may result in the domain freeing code to be unexpectedly called
> for interrupts that have no mapping in that domain. Things end pretty
> badly.
>
> Instead, add some checks to irq_domain_free_irqs_hierarchy() to make
> sure that we don't follow the hierarchy if no mapping exists for
> a given interrupt.
>
> Signed-off-by: Marc Zyngier <maz@kernel.org>
A for a good measure:
Fixes: 6a6544e520abe ("genirq/irqdomain: Remove auto-recursive hierarchy
support")
Thanks,
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2020-11-30 11:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-29 13:55 [PATCH] genirq/irqdomain: Don't try to free an interrupt that has no mapping Marc Zyngier
2020-11-30 11:45 ` Marc Zyngier [this message]
2020-11-30 13:56 ` [tip: irq/core] " tip-bot2 for Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88f1748b95169e79bb84f852dbea8fce@kernel.org \
--to=maz@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.