From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1226C34047 for ; Wed, 19 Feb 2020 11:14:48 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 63FFF2067D for ; Wed, 19 Feb 2020 11:14:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="EK4/zBLp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 63FFF2067D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id BAA604AF1B; Wed, 19 Feb 2020 06:14:47 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@kernel.org Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XMHHR7kq+HJL; Wed, 19 Feb 2020 06:14:46 -0500 (EST) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 99D464AF28; Wed, 19 Feb 2020 06:14:46 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 4936B4AF27 for ; Wed, 19 Feb 2020 06:14:45 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ngvYjLnFQOPz for ; Wed, 19 Feb 2020 06:14:44 -0500 (EST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id CB53E4AF06 for ; Wed, 19 Feb 2020 06:14:43 -0500 (EST) Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6951D24658; Wed, 19 Feb 2020 11:14:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582110882; bh=t4vzpweClqjBcv8dfE7UQXkgRAqeUVPdgkwMN4FVeg0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=EK4/zBLpN2Xq0bcVNbO+o/rj59zbrufMthyreklPzIrj8cSI8s0564Ksfw2oidBY3 KgznGxD07C86IQalFv6CpZhpI5y6vQmkbOnKMCwOictJJaUaDDNukIPALdp3hEbEeM YgiPWlcfva2qKdv6d8hjBH7dqi/QrIzd/2YsxfTk= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1j4NJQ-006UOX-Ds; Wed, 19 Feb 2020 11:14:40 +0000 MIME-Version: 1.0 Date: Wed, 19 Feb 2020 11:14:40 +0000 From: Marc Zyngier To: James Morse Subject: Re: [PATCH 3/5] kvm: arm64: Limit PMU version to ARMv8.1 In-Reply-To: References: <20200216185324.32596-1-maz@kernel.org> <20200216185324.32596-4-maz@kernel.org> Message-ID: <89155997285a33615093210d6c4de26d@kernel.org> X-Sender: maz@kernel.org User-Agent: Roundcube Webmail/1.3.10 X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: james.morse@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, peter.maydell@linaro.org, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Cc: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu T24gMjAyMC0wMi0xOSAxMDoxOCwgSmFtZXMgTW9yc2Ugd3JvdGU6Cj4gSGkgTWFyYywKPiAKPiBP biAyLzE5LzIwIDk6NDYgQU0sIE1hcmMgWnluZ2llciB3cm90ZToKPj4gT24gMjAyMC0wMi0xOCAx Nzo0MywgSmFtZXMgTW9yc2Ugd3JvdGU6Cj4+PiBIaSBNYXJjLAo+Pj4gCj4+PiBPbiAxNi8wMi8y MDIwIDE4OjUzLCBNYXJjIFp5bmdpZXIgd3JvdGU6Cj4+Pj4gT3VyIFBNVSBjb2RlIGlzIG9ubHkg aW1wbGVtZW50aW5nIHRoZSBBUk12OC4xIGZlYXR1cmVzLCBzbyBsZXQncwo+Pj4+IHN0aWNrIHRv IHRoaXMgd2hlbiByZXBvcnRpbmcgdGhlIGZlYXR1cmUgc2V0IHRvIHRoZSBndWVzdC4KPj4+IAo+ Pj4+IGRpZmYgLS1naXQgYS9hcmNoL2FybTY0L2t2bS9zeXNfcmVncy5jIGIvYXJjaC9hcm02NC9r dm0vc3lzX3JlZ3MuYwo+Pj4+IGluZGV4IDY4MmZlZGQ3NzAwZi4uMDZiMmQwZGM2YzczIDEwMDY0 NAo+Pj4+IC0tLSBhL2FyY2gvYXJtNjQva3ZtL3N5c19yZWdzLmMKPj4+PiArKysgYi9hcmNoL2Fy bTY0L2t2bS9zeXNfcmVncy5jCj4+Pj4gQEAgLTEwOTMsNiArMTA5MywxMSBAQCBzdGF0aWMgdTY0 IHJlYWRfaWRfcmVnKGNvbnN0IHN0cnVjdCBrdm1fdmNwdQo+Pj4+ICp2Y3B1LAo+Pj4+IMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgRkVBVFVSRShJRF9BQTY0SVNBUjFfR1BBKSB8 Cj4+Pj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBGRUFUVVJFKElEX0FBNjRJ U0FSMV9HUEkpKTsKPj4+PiDCoMKgwqDCoMKgwqDCoMKgIGJyZWFrOwo+Pj4+ICvCoMKgwqAgY2Fz ZSBTWVNfSURfQUE2NERGUjBfRUwxOgo+Pj4+ICvCoMKgwqDCoMKgwqDCoCAvKiBMaW1pdCBQTVUg dG8gQVJNdjguMSAqLwo+Pj4gCj4+PiBOb3QganVzdCBsaW1pdCwgYnV0IHVwZ3JhZGUgdG9vISAo Zm9yY2U/KQo+Pj4gVGhpcyBsb29rcyBzYWZlIGJlY2F1c2UgQVJNVjhfUE1VX0VWVFlQRV9FVkVO VCBhbHdheXMgaW5jbHVkZXMgdGhlCj4+PiBleHRyYSBiaXRzIHRoaXMgYWRkZWQsIGFuZCB0aGUg cmVnaXN0ZXIgaXMgYWx3YXlzIHRyYXBwZWQuCj4+IAo+PiBUaGF0J3MgZGVmaW5pdGVseSBub3Qg d2hhdCBJIGludGVuZGVkISBMZXQgbWUgZml4IHRoYXQgb25lLgo+IAo+IFdoYXQgZ29lcyB3cm9u Zz8KPiAKPiBUaGUgcmVnaXN0ZXIgZGVzY3JpcHRpb24gc2F5cyB0byBzdXBwb3J0IHY4LjEgeW91 IG5lZWQ6Cj4gfCBFeHRlbmRlZCAxNi1iaXQgUE1FVlRZUEVSPG4+X0VMMC5ldnRDb3VudCBmaWVs ZAo+IHwgSWYgRUwyIGlzIGltcGxlbWVudGVkLCB0aGUgTURDUl9FTDIuSFBNRCBjb250cm9sIGJp dAo+IAo+IEl0IGxvb2tzIGxpa2UgdGhlIGV4dGVuZGVkIFBNRVZUWVBFUiB3b3VsZCB3b3JrIHZp YSB0aGUgZW11bGF0aW9uLCBhbmQKPiBFTDIgZ3Vlc3RzIGFyZSB0b3RhbGx5IGNyYXp5Lgo+IAo+ IElzIHRoZSBTVEFMTF8qIGJpdHMgaW4gQVJNdjguMS1QTVUgdGhlIHByb2JsZW0sIC4uLiBvciB0 aGUgZXh0cmEgd29yawo+IGZvciBOVj8KCldoYXQgZ29lcyB3cm9uZyBpcyB0aGF0IG9uIGEgdjgu MCBzeXN0ZW0sIHRoZSBndWVzdCBjb3VsZCBiZSB0ZW1wdGVkIHRvCnVzZSBldmVudHMgaW4gdGhl IDB4MDQwMC0weGZmZmYgcmFuZ2UuIEl0IHdvdWxkbid0IGJyZWFrIGFueXRoaW5nLCBidXQKaXQg d291bGRuJ3QgZ2l2ZSB0aGUgZXhwZWN0ZWQgcmVzdWx0LgoKSSBkb24ndCBjYXJlIG11Y2ggZm9y IFBNVSBzdXBwb3J0IGluIEVMMiBndWVzdHMgYXQgdGhpcyBzdGFnZS4KCj4+PiBUaGUgUE1VIHZl cnNpb24gaXMgYWxzbyByZWFkYWJsZSB2aWEgSURfREZSMF9FTDEuUGVyZk1vbiwgc2hvdWxkIHRo YXQKPj4+IGJlIHNhbml0aXNlZCB0byBiZSB0aGUgc2FtZT8gKEkgZG9uJ3QgdGhpbmsgd2UndmUg aGlkZGVuIGFuIGFhcmNoNjQKPj4+IGZlYXR1cmUgdGhhdCBhbHNvIGV4aXN0ZWQgaW4gYWFyY2gz MiBiZWZvcmUpLgo+PiAKPj4gSW5kZWVkLCB5ZXQgYW5vdGhlciBvdmVyc2lnaHQuIEknbGwgZml4 IHRoYXQgdG9vLgo+IAo+IChXZWlyZCB2YXJpYXRpb24gaW4gdGhlIGFhcmNoMzIgYW5kIGFhcmNo NjQgSUQgcmVnaXN0ZXJzIGlzbid0IAo+IHNvbWV0aGluZwo+IEkgY2FyZSBhYm91dCAuLi4gd2hv IHdvdWxkIGV2ZXIgbG9vayBhdCBib3RoPykKCkEgNjRiaXQgZ3Vlc3QgcnVubmluZyBhIDMyYml0 IEVMMD8KCiAgICAgICAgIE0uCi0tIApKYXp6IGlzIG5vdCBkZWFkLiBJdCBqdXN0IHNtZWxscyBm dW5ueS4uLgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpr dm1hcm0gbWFpbGluZyBsaXN0Cmt2bWFybUBsaXN0cy5jcy5jb2x1bWJpYS5lZHUKaHR0cHM6Ly9s aXN0cy5jcy5jb2x1bWJpYS5lZHUvbWFpbG1hbi9saXN0aW5mby9rdm1hcm0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0574C3404D for ; Wed, 19 Feb 2020 11:14:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 64F1C2067D for ; Wed, 19 Feb 2020 11:14:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="su+z7FXX"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="EK4/zBLp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 64F1C2067D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=K6L+qaGWTHN/N45yq7zqBfPxg05wU1JjoFB+k/9YZEo=; b=su+z7FXXQL0jOuiuVZvkZxzJE nMuD51CjfQRURKe/y8uXZeSaKyWpUN4szTlZ8naFcxVeJLWKle7NHgvqWv6kwFn4U8y6RR5uymhPN 6TKA48KPvDvPXuBGaeykO5DdQ5tyi3xYsGMxqMRXQxMev/7VydhzgYwX6a4uW1ocIK+Kitbk/FZzi QI5VLooWzl5g4sucrnWGNnl7PIGwycrolFC76CL9qNIRer43Yl9StCo/HRFvqF+iuF1M7yxcS/i21 y1IELWUvZGH5Nfw37atihFRwbtCIb6nS3KFTyS2CaAWs6lBp+dwjQKBo9pd8OVzOI+Qm5q2rJyE+y Kpq6qwbBw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j4NJV-0004RO-Ui; Wed, 19 Feb 2020 11:14:45 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j4NJS-0004Qr-Vd for linux-arm-kernel@lists.infradead.org; Wed, 19 Feb 2020 11:14:44 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6951D24658; Wed, 19 Feb 2020 11:14:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582110882; bh=t4vzpweClqjBcv8dfE7UQXkgRAqeUVPdgkwMN4FVeg0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=EK4/zBLpN2Xq0bcVNbO+o/rj59zbrufMthyreklPzIrj8cSI8s0564Ksfw2oidBY3 KgznGxD07C86IQalFv6CpZhpI5y6vQmkbOnKMCwOictJJaUaDDNukIPALdp3hEbEeM YgiPWlcfva2qKdv6d8hjBH7dqi/QrIzd/2YsxfTk= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1j4NJQ-006UOX-Ds; Wed, 19 Feb 2020 11:14:40 +0000 MIME-Version: 1.0 Date: Wed, 19 Feb 2020 11:14:40 +0000 From: Marc Zyngier To: James Morse Subject: Re: [PATCH 3/5] kvm: arm64: Limit PMU version to ARMv8.1 In-Reply-To: References: <20200216185324.32596-1-maz@kernel.org> <20200216185324.32596-4-maz@kernel.org> Message-ID: <89155997285a33615093210d6c4de26d@kernel.org> X-Sender: maz@kernel.org User-Agent: Roundcube Webmail/1.3.10 X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: james.morse@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, peter.maydell@linaro.org, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200219_031443_072535_F1A1AF24 X-CRM114-Status: GOOD ( 17.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , kvm@vger.kernel.org, Suzuki K Poulose , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, Julien Thierry Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjAyMC0wMi0xOSAxMDoxOCwgSmFtZXMgTW9yc2Ugd3JvdGU6Cj4gSGkgTWFyYywKPiAKPiBP biAyLzE5LzIwIDk6NDYgQU0sIE1hcmMgWnluZ2llciB3cm90ZToKPj4gT24gMjAyMC0wMi0xOCAx Nzo0MywgSmFtZXMgTW9yc2Ugd3JvdGU6Cj4+PiBIaSBNYXJjLAo+Pj4gCj4+PiBPbiAxNi8wMi8y MDIwIDE4OjUzLCBNYXJjIFp5bmdpZXIgd3JvdGU6Cj4+Pj4gT3VyIFBNVSBjb2RlIGlzIG9ubHkg aW1wbGVtZW50aW5nIHRoZSBBUk12OC4xIGZlYXR1cmVzLCBzbyBsZXQncwo+Pj4+IHN0aWNrIHRv IHRoaXMgd2hlbiByZXBvcnRpbmcgdGhlIGZlYXR1cmUgc2V0IHRvIHRoZSBndWVzdC4KPj4+IAo+ Pj4+IGRpZmYgLS1naXQgYS9hcmNoL2FybTY0L2t2bS9zeXNfcmVncy5jIGIvYXJjaC9hcm02NC9r dm0vc3lzX3JlZ3MuYwo+Pj4+IGluZGV4IDY4MmZlZGQ3NzAwZi4uMDZiMmQwZGM2YzczIDEwMDY0 NAo+Pj4+IC0tLSBhL2FyY2gvYXJtNjQva3ZtL3N5c19yZWdzLmMKPj4+PiArKysgYi9hcmNoL2Fy bTY0L2t2bS9zeXNfcmVncy5jCj4+Pj4gQEAgLTEwOTMsNiArMTA5MywxMSBAQCBzdGF0aWMgdTY0 IHJlYWRfaWRfcmVnKGNvbnN0IHN0cnVjdCBrdm1fdmNwdQo+Pj4+ICp2Y3B1LAo+Pj4+IMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgRkVBVFVSRShJRF9BQTY0SVNBUjFfR1BBKSB8 Cj4+Pj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBGRUFUVVJFKElEX0FBNjRJ U0FSMV9HUEkpKTsKPj4+PiDCoMKgwqDCoMKgwqDCoMKgIGJyZWFrOwo+Pj4+ICvCoMKgwqAgY2Fz ZSBTWVNfSURfQUE2NERGUjBfRUwxOgo+Pj4+ICvCoMKgwqDCoMKgwqDCoCAvKiBMaW1pdCBQTVUg dG8gQVJNdjguMSAqLwo+Pj4gCj4+PiBOb3QganVzdCBsaW1pdCwgYnV0IHVwZ3JhZGUgdG9vISAo Zm9yY2U/KQo+Pj4gVGhpcyBsb29rcyBzYWZlIGJlY2F1c2UgQVJNVjhfUE1VX0VWVFlQRV9FVkVO VCBhbHdheXMgaW5jbHVkZXMgdGhlCj4+PiBleHRyYSBiaXRzIHRoaXMgYWRkZWQsIGFuZCB0aGUg cmVnaXN0ZXIgaXMgYWx3YXlzIHRyYXBwZWQuCj4+IAo+PiBUaGF0J3MgZGVmaW5pdGVseSBub3Qg d2hhdCBJIGludGVuZGVkISBMZXQgbWUgZml4IHRoYXQgb25lLgo+IAo+IFdoYXQgZ29lcyB3cm9u Zz8KPiAKPiBUaGUgcmVnaXN0ZXIgZGVzY3JpcHRpb24gc2F5cyB0byBzdXBwb3J0IHY4LjEgeW91 IG5lZWQ6Cj4gfCBFeHRlbmRlZCAxNi1iaXQgUE1FVlRZUEVSPG4+X0VMMC5ldnRDb3VudCBmaWVs ZAo+IHwgSWYgRUwyIGlzIGltcGxlbWVudGVkLCB0aGUgTURDUl9FTDIuSFBNRCBjb250cm9sIGJp dAo+IAo+IEl0IGxvb2tzIGxpa2UgdGhlIGV4dGVuZGVkIFBNRVZUWVBFUiB3b3VsZCB3b3JrIHZp YSB0aGUgZW11bGF0aW9uLCBhbmQKPiBFTDIgZ3Vlc3RzIGFyZSB0b3RhbGx5IGNyYXp5Lgo+IAo+ IElzIHRoZSBTVEFMTF8qIGJpdHMgaW4gQVJNdjguMS1QTVUgdGhlIHByb2JsZW0sIC4uLiBvciB0 aGUgZXh0cmEgd29yawo+IGZvciBOVj8KCldoYXQgZ29lcyB3cm9uZyBpcyB0aGF0IG9uIGEgdjgu MCBzeXN0ZW0sIHRoZSBndWVzdCBjb3VsZCBiZSB0ZW1wdGVkIHRvCnVzZSBldmVudHMgaW4gdGhl IDB4MDQwMC0weGZmZmYgcmFuZ2UuIEl0IHdvdWxkbid0IGJyZWFrIGFueXRoaW5nLCBidXQKaXQg d291bGRuJ3QgZ2l2ZSB0aGUgZXhwZWN0ZWQgcmVzdWx0LgoKSSBkb24ndCBjYXJlIG11Y2ggZm9y IFBNVSBzdXBwb3J0IGluIEVMMiBndWVzdHMgYXQgdGhpcyBzdGFnZS4KCj4+PiBUaGUgUE1VIHZl cnNpb24gaXMgYWxzbyByZWFkYWJsZSB2aWEgSURfREZSMF9FTDEuUGVyZk1vbiwgc2hvdWxkIHRo YXQKPj4+IGJlIHNhbml0aXNlZCB0byBiZSB0aGUgc2FtZT8gKEkgZG9uJ3QgdGhpbmsgd2UndmUg aGlkZGVuIGFuIGFhcmNoNjQKPj4+IGZlYXR1cmUgdGhhdCBhbHNvIGV4aXN0ZWQgaW4gYWFyY2gz MiBiZWZvcmUpLgo+PiAKPj4gSW5kZWVkLCB5ZXQgYW5vdGhlciBvdmVyc2lnaHQuIEknbGwgZml4 IHRoYXQgdG9vLgo+IAo+IChXZWlyZCB2YXJpYXRpb24gaW4gdGhlIGFhcmNoMzIgYW5kIGFhcmNo NjQgSUQgcmVnaXN0ZXJzIGlzbid0IAo+IHNvbWV0aGluZwo+IEkgY2FyZSBhYm91dCAuLi4gd2hv IHdvdWxkIGV2ZXIgbG9vayBhdCBib3RoPykKCkEgNjRiaXQgZ3Vlc3QgcnVubmluZyBhIDMyYml0 IEVMMD8KCiAgICAgICAgIE0uCi0tIApKYXp6IGlzIG5vdCBkZWFkLiBJdCBqdXN0IHNtZWxscyBm dW5ueS4uLgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K bGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZy YWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGlu dXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89324C34047 for ; Wed, 19 Feb 2020 11:14:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5A38E24656 for ; Wed, 19 Feb 2020 11:14:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582110884; bh=t4vzpweClqjBcv8dfE7UQXkgRAqeUVPdgkwMN4FVeg0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=CZhR43oR2nrexk0xfrMbxuZ8BoX/giipOzgXDoEeOraQnUJUp1rzke6ocvrGFf0Mf GpW3ogngSbJGUW0jV956JBntbZQxrTJy0zo5W6P3hKyQBUVXLRLj2ldmY+1KVDga/U ngO8p1QWZDAyfE613wMaA7cYYnobYXEn6ZtUm6tQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726558AbgBSLOn (ORCPT ); Wed, 19 Feb 2020 06:14:43 -0500 Received: from mail.kernel.org ([198.145.29.99]:60200 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726469AbgBSLOn (ORCPT ); Wed, 19 Feb 2020 06:14:43 -0500 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6951D24658; Wed, 19 Feb 2020 11:14:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582110882; bh=t4vzpweClqjBcv8dfE7UQXkgRAqeUVPdgkwMN4FVeg0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=EK4/zBLpN2Xq0bcVNbO+o/rj59zbrufMthyreklPzIrj8cSI8s0564Ksfw2oidBY3 KgznGxD07C86IQalFv6CpZhpI5y6vQmkbOnKMCwOictJJaUaDDNukIPALdp3hEbEeM YgiPWlcfva2qKdv6d8hjBH7dqi/QrIzd/2YsxfTk= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1j4NJQ-006UOX-Ds; Wed, 19 Feb 2020 11:14:40 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Wed, 19 Feb 2020 11:14:40 +0000 From: Marc Zyngier To: James Morse Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, Peter Maydell , Julien Thierry , Suzuki K Poulose Subject: Re: [PATCH 3/5] kvm: arm64: Limit PMU version to ARMv8.1 In-Reply-To: References: <20200216185324.32596-1-maz@kernel.org> <20200216185324.32596-4-maz@kernel.org> Message-ID: <89155997285a33615093210d6c4de26d@kernel.org> X-Sender: maz@kernel.org User-Agent: Roundcube Webmail/1.3.10 X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: james.morse@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, peter.maydell@linaro.org, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 2020-02-19 10:18, James Morse wrote: > Hi Marc, > > On 2/19/20 9:46 AM, Marc Zyngier wrote: >> On 2020-02-18 17:43, James Morse wrote: >>> Hi Marc, >>> >>> On 16/02/2020 18:53, Marc Zyngier wrote: >>>> Our PMU code is only implementing the ARMv8.1 features, so let's >>>> stick to this when reporting the feature set to the guest. >>> >>>> diff --git a/arch/arm64/kvm/sys_regs.c b/arch/arm64/kvm/sys_regs.c >>>> index 682fedd7700f..06b2d0dc6c73 100644 >>>> --- a/arch/arm64/kvm/sys_regs.c >>>> +++ b/arch/arm64/kvm/sys_regs.c >>>> @@ -1093,6 +1093,11 @@ static u64 read_id_reg(const struct kvm_vcpu >>>> *vcpu, >>>>                   FEATURE(ID_AA64ISAR1_GPA) | >>>>                   FEATURE(ID_AA64ISAR1_GPI)); >>>>          break; >>>> +    case SYS_ID_AA64DFR0_EL1: >>>> +        /* Limit PMU to ARMv8.1 */ >>> >>> Not just limit, but upgrade too! (force?) >>> This looks safe because ARMV8_PMU_EVTYPE_EVENT always includes the >>> extra bits this added, and the register is always trapped. >> >> That's definitely not what I intended! Let me fix that one. > > What goes wrong? > > The register description says to support v8.1 you need: > | Extended 16-bit PMEVTYPER_EL0.evtCount field > | If EL2 is implemented, the MDCR_EL2.HPMD control bit > > It looks like the extended PMEVTYPER would work via the emulation, and > EL2 guests are totally crazy. > > Is the STALL_* bits in ARMv8.1-PMU the problem, ... or the extra work > for NV? What goes wrong is that on a v8.0 system, the guest could be tempted to use events in the 0x0400-0xffff range. It wouldn't break anything, but it wouldn't give the expected result. I don't care much for PMU support in EL2 guests at this stage. >>> The PMU version is also readable via ID_DFR0_EL1.PerfMon, should that >>> be sanitised to be the same? (I don't think we've hidden an aarch64 >>> feature that also existed in aarch32 before). >> >> Indeed, yet another oversight. I'll fix that too. > > (Weird variation in the aarch32 and aarch64 ID registers isn't > something > I care about ... who would ever look at both?) A 64bit guest running a 32bit EL0? M. -- Jazz is not dead. It just smells funny...