From: Bart Van Assche <bvanassche@acm.org>
To: Ming Lei <ming.lei@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH 06/10] block: Fix the number of segment calculations
Date: Thu, 3 Nov 2022 12:32:50 -0700 [thread overview]
Message-ID: <89172337-0698-e3ef-611f-5487f9ef53bb@acm.org> (raw)
In-Reply-To: <Y2HGOj/OCKoZr7ej@T590>
On 11/1/22 18:22, Ming Lei wrote:
> On Tue, Nov 01, 2022 at 10:23:32AM -0700, Bart Van Assche wrote:
>> On 10/19/22 15:23, Bart Van Assche wrote:
>>> Since multi-page bvecs are supported there can be multiple segments per
>>> bvec (see also bvec_split_segs()). Hence this patch that calculates the
>>> number of segments per bvec instead of assuming that there is only one
>>> segment per bvec.
>>
>> (replying to my own email)
>>
>> Hi Ming,
>>
>> Do you agree that this patch fixes a bug introduced by the multi-page bvec
>> code and also that it is required even if the segment size is larger than
>> the page size?
>
> No, multi-age bvec is only applied on normal IO bvec, and it isn't used
> in bio_add_pc_page(), so there isn't such issue in blk_rq_append_bio(),
> that is why we needn't to split passthrough bio.
Hi Ming,
Thanks for the feedback. I will fix the description of this patch.
Bart.
next prev parent reply other threads:[~2022-11-03 19:32 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-19 22:23 [PATCH 00/10] Support DMA segments smaller than the page size Bart Van Assche
2022-10-19 22:23 ` [PATCH 01/10] block: Remove request.write_hint Bart Van Assche
2022-10-21 1:59 ` Ming Lei
2022-10-19 22:23 ` [PATCH 02/10] block: Constify most queue limits pointers Bart Van Assche
2022-10-21 2:01 ` Ming Lei
2022-10-19 22:23 ` [PATCH 03/10] block: Micro-optimize get_max_segment_size() Bart Van Assche
2022-10-21 2:17 ` Ming Lei
2022-10-19 22:23 ` [PATCH 04/10] block: Add support for small segments in blk_rq_map_user_iov() Bart Van Assche
2022-10-19 22:23 ` [PATCH 05/10] block: Introduce QUEUE_FLAG_SUB_PAGE_SEGMENTS Bart Van Assche
2022-10-19 22:23 ` [PATCH 06/10] block: Fix the number of segment calculations Bart Van Assche
2022-11-01 17:23 ` Bart Van Assche
2022-11-02 1:22 ` Ming Lei
2022-11-03 19:32 ` Bart Van Assche [this message]
2022-10-19 22:23 ` [PATCH 07/10] block: Add support for segments smaller than the page size Bart Van Assche
2022-10-19 22:23 ` [PATCH 08/10] scsi: core: Set the SUB_PAGE_SEGMENTS request queue flag Bart Van Assche
2022-10-19 22:23 ` [PATCH 09/10] scsi_debug: Support configuring the maximum segment size Bart Van Assche
2022-10-19 22:23 ` [PATCH 10/10] null_blk: " Bart Van Assche
2022-10-20 23:13 ` Damien Le Moal
2022-10-20 23:34 ` Bart Van Assche
2022-10-20 23:39 ` Damien Le Moal
2022-10-21 0:39 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89172337-0698-e3ef-611f-5487f9ef53bb@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.