From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=91.218.175.158 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794966941; b=2j0OXC7mjiuUIUYndngZOAh4lAgiJYLvloeNHGUFQMTnhjxiwtU6BfJKWrFAdDOBFhDB pWJg23x28RqgEbN5Q9jLXMPmsU2HfaO6qKsa1oBi76PukDd0di8AC5AWrMoEoLJL8bTU7 a5fEg9U7wSldV9sCHddn668+dVxH7rfyCX9krrPfwA2tZyBM6drRd5xclEGLS+DyQcE7y ZcqgqbebI3PYSG3fKb0kAVBJFa/7mkjignX3NuVLoxGUveMPleU/eCPz6XBir8Dr0kt5L ndrBym0t7vQOVAhvV/xvFr0Qfv3K04gZgeJdE206EbPr5hlELgzkY9XYNSbF3zSWvWg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794966941; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:Message-ID:Date:MIME-Version:User-Agent: Subject:To:Cc:References:Content-Language:From:In-Reply-To: Content-Type:Content-Transfer-Encoding; bh=n6+eDFFvL/Wsk0eeysYpdGNLwTPv8Y7kp0pCYvn78f0=; b=QTEwoBelJD/4kEYlbUqJ86YQ0KtVTP2T2bpn7CaxwxfJctdoc/sPo/Fn2k4bk8s5jdMQ vOScZKIyuMDIaXcC3FhzZfppM7AwLG4Q7taBtdRXTsdqFDiRJQwITA+Z0gb5nXJCiVq4h xiNHorXBj6faRXbsH32lKjuRFr4MAZkP5Gw4cThwJQ/mn3EmgxhUkbvjeZSS4kox/E015 2R20uJuXMj7Eq7rqjE30gWz9x891CEb+nK/iYZnSo0wgbJ9GdtY3L7N5vfgh45TrKWfBl O7lz/JX34n3x0+Jq94nTbcbUSm3A/ukWCFmYFwFcYKOFDPQP58tvTnj573bCzUhxqhA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=GgIYDdkN; arc=none smtp.remote-ip=91.218.175.158 Received: from mta0.migadu.com (out-158.mta0.migadu.com [91.218.175.158]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7B2E60A2627 for ; Wed, 18 Nov 2026 01:55:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org B7B2E60A2627 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=GgIYDdkN X-Envelope-To: linux-kselftest@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=inCj9hgFOM+3wUeyAcIWcO42wDOsOp5Vk/7hHTYE1G8=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1794966938; v=1; x=1795571738; b=GgIYDdkN89LjuVdl5y8CJdY0zGpkAa8UTyK6HGJFRvf99H8IWLM7mkVZsmfh+Eg3cgfUDG9x WdZR1txON9onqNfbhIEmx6STjl2UXJUGQfWkoNvDfNWDs13QGX6I+IVmeLLTTvKndio+lzR+4Yo pAYRcctm4kqK/9yL9LXBJqMs= X-Envelope-To: linux-kselftest@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id 0ae421e0b46adfb2; Wed, 18 Nov 2026 01:55:23 +0000 X-Mizu-Trace-ID: 0ae421e0b46adfb2 X-Migadu-Flow: FLOW_OUT Message-ID: <8922213b-d734-4f43-9648-97b3fce1cfc6@linux.dev> Date: Wed, 18 Nov 2026 09:55:17 +0800 X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH bpf-next v2 1/9] bpf: Add log support for tracing link_create To: Alexei Starovoitov , bpf@vger.kernel.org Cc: Daniel Borkmann , John Fastabend , Andrii Nakryiko , Eduard Zingerman , Kumar Kartikeya Dwivedi , Martin KaFai Lau , Song Liu , Yonghong Song , Jiri Olsa , Emil Tsalapatis , Ihor Solodrai , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , KP Singh , Matt Bobrowski , Shuah Khan , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, netdev@vger.kernel.org References: <20261114150610.84507-1-leon.hwang@linux.dev> <20261114150610.84507-2-leon.hwang@linux.dev> Content-Language: en-US From: Leon Hwang In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 17/11/26 13:22, Alexei Starovoitov wrote: > On Sat, Nov 14, 2026 at 07:06 AM Leon Hwang wrote: > > tldr: pls use uapi names where possible: > >> + bpf_log(log, "tgt_prog_fd and btf_id must be both set or both unset.\n"); > > The uapi fields are target_fd and target_btf_id. > tgt_prog_fd and btf_id are arguments of this function. > Patches 2, 3 and 4 say target_fd for the same field. > >> + bpf_log(log, "Only allow re-attach for tracing and lsm progs.\n"); > > I think this one misleads. A freplace prog can re-attach. > It has to pass target_fd and target_btf_id. > The comment above the check says so. > >> + bpf_log(log, "Invalid attach_btf.\n"); > > attach_btf is a field of bpf_prog_aux. The user never set it. > NULL means that the prog was loaded with attach_prog_fd. > Such a prog can't re-attach at all. > >> + bpf_log(log, "Invalid kprobe_write_ctx.\n"); > > Another bit of bpf_prog_aux. > The rule is that both progs write to pt_regs, or none. > >> + bpf_log(log, "Invalid tracing attach_type.\n"); > > LSM progs get here too. Ack. Will update the log messages. Thanks, Leon > [...]