From: Richard Weinberger <richard@sigma-star.at>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ubi: Fix filesystem corruption on detach when fastmap enabled
Date: Tue, 16 Jan 2018 14:22:57 +0100 [thread overview]
Message-ID: <8925017.tvIN1CM1GY@blindfold> (raw)
In-Reply-To: <CABatt_xtfoXRpfOYBPZwD=PmTx_+H+X5gqbYGGLY=KtxVbCQJw@mail.gmail.com>
Heiko, Martin,
Am Dienstag, 16. Januar 2018, 10:11:41 CET schrieb Martin Townsend:
> Ah. Must be the mail client. Sorry about that I'll setup git send-mail
> for v2. I'll wait to see what Richard has to say in case there is a
> better fix.
Thanks for letting me know!
Indeed, there is a problem. I'm a little astonished that nobody noticed so
far.
Most likely because while detaching UBI in Linux mostly no Fastmap work is
scheduled,
and therefore in most cases flush_work(&ubi->fm_work) does nothing.
As you noticed in U-Boot the story is different, you always update the Fastmap
upon detach.
Martin, can you please explain what corruption you see?
From reading the code I'd assume that you miss volumes but a full scan would
recover everything.
For Linux I suggest this fix:
next prev parent reply other threads:[~2018-01-16 13:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-12 19:03 [U-Boot] [PATCH] ubi: Fix filesystem corruption on detach when fastmap enabled Martin Townsend
2018-01-15 11:30 ` Heiko Schocher
2018-01-15 12:13 ` Martin Townsend
2018-01-16 5:43 ` Heiko Schocher
2018-01-16 9:11 ` Martin Townsend
2018-01-16 13:22 ` Richard Weinberger [this message]
2018-01-16 14:13 ` Martin Townsend
2018-01-17 15:47 ` Richard Weinberger
2018-01-17 15:47 ` [U-Boot] " Richard Weinberger
2018-01-17 22:02 ` Martin Townsend
2018-01-17 22:02 ` [U-Boot] " Martin Townsend
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8925017.tvIN1CM1GY@blindfold \
--to=richard@sigma-star.at \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.