All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Bruce Richardson <bruce.richardson@intel.com>, <dev@dpdk.org>
Cc: <lylavoie@iol.unh.edu>, <probb@iol.unh.edu>,
	<david.marchand@redhat.com>,  <stable@dpdk.org>
Subject: Re: [PATCH 7/7] test/debug: fix unit test on FreeBSD
Date: Fri, 20 Mar 2026 15:00:11 +0100	[thread overview]
Message-ID: <892b42f6-24ab-4072-848a-1b9f7f03e39b@intel.com> (raw)
In-Reply-To: <20260319171334.1151425-8-bruce.richardson@intel.com>

On 3/19/2026 6:11 PM, Bruce Richardson wrote:
> Fix the test_debug unit test on FreeBSD by:
> * passing no-telemetry to the additional process calls
> * ensuring that we always use the no-huge and no-shconf params
> * removing the dependency on procfs to get the exe and using argv[0]
>    instead
> 
> Bugzilla ID: 761 (partial fix)
> Fixes: 764bf26873b9 ("add FreeBSD support")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
>   app/test/process.h    | 11 ++++++++---
>   app/test/test_debug.c |  6 +++---
>   2 files changed, 11 insertions(+), 6 deletions(-)
> 
> diff --git a/app/test/process.h b/app/test/process.h
> index df43966a2a..46b69ce330 100644
> --- a/app/test/process.h
> +++ b/app/test/process.h
> @@ -96,7 +96,7 @@ process_dup(const char *const argv[], int numargs, const char *env_value)
>   	int driver_path_num;
>   	int argv_num;
>   	int i, status;
> -	char path[32];
> +	char *path;
>   #ifdef RTE_LIB_PDUMP
>   #ifdef RTE_NET_RING
>   	rte_thread_t thread;
> @@ -188,8 +188,13 @@ process_dup(const char *const argv[], int numargs, const char *env_value)
>   		/* set the environment variable */
>   		if (setenv(RECURSIVE_ENV_VAR, env_value, 1) != 0)
>   			rte_panic("Cannot export environment variable\n");
> -
> -		strlcpy(path, "/proc/" self "/" exe, sizeof(path));
> +#ifdef RTE_EXEC_ENV_LINUX
> +		char path_buf[32];
> +		strlcpy(path_buf, "/proc/" self "/" exe, sizeof(path_buf));
> +		path = path_buf;
> +#else
> +		path = argv_cpy[0];

Why can't we just use argv_cpy everywhere?

Otherwise,

Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
-- 
Thanks,
Anatoly

  reply	other threads:[~2026-03-20 14:00 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-19 17:11 [PATCH 0/7] Get fast-test suite to run on FreeBSD Bruce Richardson
2026-03-19 17:11 ` [PATCH 1/7] test/timer_secondary: skip test " Bruce Richardson
2026-03-20 14:03   ` Burakov, Anatoly
2026-03-19 17:11 ` [PATCH 2/7] test/eal_flags: " Bruce Richardson
2026-03-20 14:02   ` Burakov, Anatoly
2026-03-19 17:11 ` [PATCH 3/7] test/pdump: " Bruce Richardson
2026-03-19 17:16   ` Bruce Richardson
2026-03-21 16:14     ` Stephen Hemminger
2026-03-23  9:07       ` Bruce Richardson
2026-03-19 17:11 ` [PATCH 4/7] test/secondary_process: " Bruce Richardson
2026-03-20 14:02   ` Burakov, Anatoly
2026-03-19 17:11 ` [PATCH 5/7] test/external_memory: " Bruce Richardson
2026-03-20 14:01   ` Burakov, Anatoly
2026-03-19 17:11 ` [PATCH 6/7] test/interrupts: " Bruce Richardson
2026-03-20 14:01   ` Burakov, Anatoly
2026-03-19 17:11 ` [PATCH 7/7] test/debug: fix unit " Bruce Richardson
2026-03-20 14:00   ` Burakov, Anatoly [this message]
2026-03-20 14:02   ` David Marchand
2026-03-20 14:18     ` Bruce Richardson
2026-03-19 20:15 ` [PATCH 0/7] Get fast-test suite to run " Patrick Robb
2026-03-19 20:44 ` Patrick Robb
2026-03-20  8:33   ` Bruce Richardson
2026-03-20 14:25 ` David Marchand
2026-03-20 14:31   ` Bruce Richardson
2026-03-20 16:11 ` [PATCH v2 0/2] " Bruce Richardson
2026-03-20 16:11   ` [PATCH v2 1/2] test: fix failing tests " Bruce Richardson
2026-03-25 22:48     ` Thomas Monjalon
2026-03-20 16:11   ` [PATCH v2 2/2] test: simplify spawning extra test processes Bruce Richardson
2026-03-25 22:50     ` Thomas Monjalon
2026-03-24 16:31   ` [PATCH v2 0/2] Get fast-test suite to run on FreeBSD Adam Hassick
2026-04-08 17:44 ` [PATCH v3 " Bruce Richardson
2026-04-08 17:44   ` [PATCH v3 1/2] test: fix failing tests " Bruce Richardson
2026-04-08 17:44   ` [PATCH v3 2/2] test: simplify spawning extra test processes Bruce Richardson
2026-04-21 15:27     ` Bruce Richardson
2026-04-21 19:52 ` [PATCH v4 0/2] Get fast-test suite to run on FreeBSD Bruce Richardson
2026-04-21 19:52   ` [PATCH v4 1/2] test: fix failing tests " Bruce Richardson
2026-04-22  8:19     ` Mcnamara, John
2026-04-21 19:52   ` [PATCH v4 2/2] test: simplify spawning extra test processes Bruce Richardson
2026-04-22  8:20     ` Mcnamara, John
2026-04-29 14:56   ` [PATCH v4 0/2] Get fast-test suite to run on FreeBSD David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=892b42f6-24ab-4072-848a-1b9f7f03e39b@intel.com \
    --to=anatoly.burakov@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=lylavoie@iol.unh.edu \
    --cc=probb@iol.unh.edu \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.