All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adriana Kobylak <anoo@linux.ibm.com>
To: "P. Priyatharshan" <PriyatharshanP@hcl.com>
Cc: openbmc@lists.ozlabs.org, anoo@us.ibm.com, ojayanth@in.ibm.com,
	gmills@linux.vnet.ibm.com, "Velumani T-ERS,
	HCLTech" <velumanit@hcl.com>,
	ratagupt@linux.vnet.ibm.com
Subject: Re: Multi host bios upgrade support in phosphor-bmc-code-mgmt:
Date: Mon, 05 Oct 2020 16:41:12 -0500	[thread overview]
Message-ID: <893bbe2bbfe35c6ccdea0988c8ec1de9@linux.vnet.ibm.com> (raw)
In-Reply-To: <TY2PR04MB3311812DB85A11934F044FB4CA0C0@TY2PR04MB3311.apcprd04.prod.outlook.com>

Hi Priyatharshan,

>  Object : /xyz/openbmc_project/software/[FIRMWARE_VERSION]_[DEVICE]
> where device could be host1, 2, ...,N
>  Interface : xyz.openbmc_project.Software.Activation
> 
>  Please confirm if our understanding is correct.

I meant that to generate the id, which currently uses the version 
string, would instead use the version string plus the string for the 
name of the device where it's stored in order to generate the hash. For 
example, today the code calls "SHA512_Update("version")", where 
"version" is for example "2.9.0-dev-663-g2e34bb673". Instead the code 
would detect this version is stored let's say in device "mtd1" or 
"mmcblk0p1", it'd then append that device string to version, ex: 
"2.9.0-dev-663-g2e34bb673-mmcblk0p1" and pass that string to 
SHA512_Update(), therefore creating a different hash depending where 
that version of bmc code is stored.

Note that this is for BMC versions only. We discussed that for host 
versions, we'd need to modify the code to add a "os-release" file under 
/media/ that contained the host version information similar to the BMC's 
os-release file. In addition, we'd need to somehow determine that those 
files were for host (Bios) versions instead of BMC ones. Perhaps 
os-release could have an additional field added to specify the purpose.


> Adriana, Any tentative timeline on your commits availability [generate
> the id based on firmware version plus the device or volume ]

I'd say by early next year at the latest.

  reply	other threads:[~2020-10-05 21:43 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-21 17:49 Multi host bios upgrade support in phosphor-bmc-code-mgmt: P. Priyatharshan
2020-09-21 19:46 ` Patrick Williams
2020-09-21 19:46   ` Patrick Williams
2020-09-21 20:58   ` Adriana Kobylak
2020-09-21 20:58     ` Adriana Kobylak
2020-10-01 15:52     ` P. Priyatharshan
2020-10-05 17:29       ` P. Priyatharshan
2020-10-05 21:41         ` Adriana Kobylak [this message]
2020-10-15 17:16           ` P. Priyatharshan
2020-10-15 19:28             ` Vijay Khemka
2020-10-19 17:08               ` P. Priyatharshan
2020-10-19 19:25                 ` Adriana Kobylak
2020-10-21  0:10                   ` Vijay Khemka
2020-10-21  5:27                     ` P. Priyatharshan
2020-10-23 13:34                       ` P. Priyatharshan
2020-10-28 15:20                         ` P. Priyatharshan
2020-10-30 18:52                           ` Adriana Kobylak
2020-11-03 21:01                             ` Patrick Williams
2020-11-09 20:35                               ` Adriana Kobylak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=893bbe2bbfe35c6ccdea0988c8ec1de9@linux.vnet.ibm.com \
    --to=anoo@linux.ibm.com \
    --cc=PriyatharshanP@hcl.com \
    --cc=anoo@us.ibm.com \
    --cc=gmills@linux.vnet.ibm.com \
    --cc=ojayanth@in.ibm.com \
    --cc=openbmc@lists.ozlabs.org \
    --cc=ratagupt@linux.vnet.ibm.com \
    --cc=velumanit@hcl.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.