From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
Chaitanya Kulkarni <kch@nvidia.com>
Subject: Re: [PATCH 2/4] nvme: split command copy into a helper
Date: Mon, 6 Dec 2021 09:33:00 -0700 [thread overview]
Message-ID: <89485d2c-a0e2-c7fb-90fc-ecc500e49127@kernel.dk> (raw)
In-Reply-To: <Ya29+OXo3SBh7UNo@infradead.org>
On 12/6/21 12:38 AM, Christoph Hellwig wrote:
> As mentioned last time I really don't like the proliferation of
> tiny helpers with just two callers. See my patch I responded with
> for my alternative.
I tend to agree with you, but for this particular case I really don't
think it's better to not have the helper. I did try that version too,
but you end up with several sites duplicating it. So while I agree in
general, I don't think this one applies.
--
Jens Axboe
next prev parent reply other threads:[~2021-12-06 16:33 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-03 21:45 [PATCHSET v2 0/4] Add support for list issue Jens Axboe
2021-12-03 21:45 ` [PATCH 1/4] block: add mq_ops->queue_rqs hook Jens Axboe
2021-12-04 10:43 ` Hannes Reinecke
2021-12-04 20:13 ` Jens Axboe
2021-12-05 9:07 ` Hannes Reinecke
2021-12-05 13:09 ` Jens Axboe
2021-12-03 21:45 ` [PATCH 2/4] nvme: split command copy into a helper Jens Axboe
2021-12-04 10:44 ` Hannes Reinecke
2021-12-06 7:38 ` Christoph Hellwig
2021-12-06 16:33 ` Jens Axboe [this message]
2021-12-03 21:45 ` [PATCH 3/4] nvme: separate command prep and issue Jens Axboe
2021-12-04 10:45 ` Hannes Reinecke
2021-12-03 21:45 ` [PATCH 4/4] nvme: add support for mq_ops->queue_rqs() Jens Axboe
2021-12-04 10:47 ` Hannes Reinecke
2021-12-06 7:40 ` Christoph Hellwig
2021-12-06 16:33 ` Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2021-12-16 16:38 [PATCHSET v5 0/4] Add support for list issue Jens Axboe
2021-12-16 16:38 ` [PATCH 2/4] nvme: split command copy into a helper Jens Axboe
2021-12-16 17:53 ` Christoph Hellwig
2021-12-16 16:05 [PATCHSET v4 0/4] Add support for list issue Jens Axboe
2021-12-16 16:05 ` [PATCH 2/4] nvme: split command copy into a helper Jens Axboe
2021-12-15 16:24 [PATCHSET v3 0/4] Add support for list issue Jens Axboe
2021-12-15 16:24 ` [PATCH 2/4] nvme: split command copy into a helper Jens Axboe
2021-12-16 9:01 ` Christoph Hellwig
2021-12-16 12:17 ` Max Gurtovoy
2021-11-17 3:38 [PATCHSET 0/4] Add support for list issue Jens Axboe
2021-11-17 3:38 ` [PATCH 2/4] nvme: split command copy into a helper Jens Axboe
2021-11-17 6:15 ` Christoph Hellwig
2021-11-17 15:44 ` Jens Axboe
2021-11-18 7:54 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89485d2c-a0e2-c7fb-90fc-ecc500e49127@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=kch@nvidia.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.