From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Xu, Ting" <ting.xu@intel.com>,
"Liu, KevinX" <kevinx.liu@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Yang, Qiming" <qiming.yang@intel.com>,
"Yang, SteveX" <stevex.yang@intel.com>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>,
"Liu, KevinX" <kevinx.liu@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [PATCH v2 1/2] net/ice: fix Tx offload path choice
Date: Fri, 4 Mar 2022 03:31:56 +0000 [thread overview]
Message-ID: <894899b025bc41a29aeff249740a7f92@intel.com> (raw)
In-Reply-To: <BL0PR11MB325004D859B0F23723C6C484F8059@BL0PR11MB3250.namprd11.prod.outlook.com>
> -----Original Message-----
> From: Xu, Ting <ting.xu@intel.com>
> Sent: Friday, March 4, 2022 11:19 AM
> To: Liu, KevinX <kevinx.liu@intel.com>; dev@dpdk.org
> Cc: Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Yang, SteveX <stevex.yang@intel.com>; Yigit, Ferruh
> <ferruh.yigit@intel.com>; Liu, KevinX <kevinx.liu@intel.com>; stable@dpdk.org
> Subject: RE: [PATCH v2 1/2] net/ice: fix Tx offload path choice
>
> > -----Original Message-----
> > From: Kevin Liu <kevinx.liu@intel.com>
> > Sent: Wednesday, December 29, 2021 5:37 PM
> > To: dev@dpdk.org
> > Cc: Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
> > <qi.z.zhang@intel.com>; Yang, SteveX <stevex.yang@intel.com>; Yigit,
> > Ferruh <ferruh.yigit@intel.com>; Liu, KevinX <kevinx.liu@intel.com>;
> > stable@dpdk.org
> > Subject: [PATCH v2 1/2] net/ice: fix Tx offload path choice
> >
> > Testpmd forwards packets in checksum mode that it needs to calculate
> > the checksum of each layer's protocol.
> >
> > When setting the hardware calculates the outer UDP checksum and the
> > software calculates the outer IP checksum, the dev->tx_pkt_burst in
> > ice_set_tx_function is set to ice_xmit_pkts_vec_avx2.
> > The inner and outer UDP checksum of the tunnel packet after forwarding
> > is wrong.The dev->tx_pkt_burst should be set to ice_xmit_pkts.
> >
> > The patch adds RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM to
> > ICE_TX_NO_VECTOR_FLAGS,set dev->tx_pkt_burst to ice_xmit_pkts.After
> > the tunnel packet is forwarded, the inner and outer UDP checksum is correct.
> >
> > At the same time, the patch of "net/ice: fix Tx Checksum offload" will
> > cause interrupt errors in a special case that only inner IP and inner
> > UDP checksum are set for hardware calculation.The patch is updating
> > ICE_TX_NO_VECTOR_FLAGS, the problem can be solved, so I will restore
> > the code modification of that patch.
> >
> > Fixes: 28f9002ab67f ("net/ice: add Tx AVX512 offload path")
> > Fixes: 295968d17407 ("ethdev: add namespace")
> > Fixes: 17c7d0f9d6a4 ("net/ice: support basic Rx/Tx")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Kevin Liu <kevinx.liu@intel.com>
> > ---
> > drivers/net/ice/ice_rxtx.c | 41 ++++++-------------
> > drivers/net/ice/ice_rxtx_vec_common.h | 59
> > +++++++++------------------
> > 2 files changed, 31 insertions(+), 69 deletions(-)
> >
> > diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c
> > index 4f218bcd0d..041f4bc91f 100644
> > --- a/drivers/net/ice/ice_rxtx.c
> > +++ b/drivers/net/ice/ice_rxtx.c
> > @@ -2501,35 +2501,18 @@ ice_txd_enable_checksum(uint64_t ol_flags,
> > << ICE_TX_DESC_LEN_MACLEN_S;
> >
> > /* Enable L3 checksum offloads */
> > - /*Tunnel package usage outer len enable L3 checksum offload*/
> > - if (ol_flags & RTE_MBUF_F_TX_TUNNEL_MASK) {
> > - if (ol_flags & RTE_MBUF_F_TX_IP_CKSUM) {
> > - *td_cmd |= ICE_TX_DESC_CMD_IIPT_IPV4_CSUM;
> > - *td_offset |= (tx_offload.outer_l3_len >> 2) <<
> > - ICE_TX_DESC_LEN_IPLEN_S;
> > - } else if (ol_flags & RTE_MBUF_F_TX_IPV4) {
> > - *td_cmd |= ICE_TX_DESC_CMD_IIPT_IPV4;
> > - *td_offset |= (tx_offload.outer_l3_len >> 2) <<
> > - ICE_TX_DESC_LEN_IPLEN_S;
> > - } else if (ol_flags & RTE_MBUF_F_TX_IPV6) {
> > - *td_cmd |= ICE_TX_DESC_CMD_IIPT_IPV6;
> > - *td_offset |= (tx_offload.outer_l3_len >> 2) <<
> > - ICE_TX_DESC_LEN_IPLEN_S;
> > - }
> > - } else {
> > - if (ol_flags & RTE_MBUF_F_TX_IP_CKSUM) {
> > - *td_cmd |= ICE_TX_DESC_CMD_IIPT_IPV4_CSUM;
> > - *td_offset |= (tx_offload.l3_len >> 2) <<
> > - ICE_TX_DESC_LEN_IPLEN_S;
> > - } else if (ol_flags & RTE_MBUF_F_TX_IPV4) {
> > - *td_cmd |= ICE_TX_DESC_CMD_IIPT_IPV4;
> > - *td_offset |= (tx_offload.l3_len >> 2) <<
> > - ICE_TX_DESC_LEN_IPLEN_S;
> > - } else if (ol_flags & RTE_MBUF_F_TX_IPV6) {
> > - *td_cmd |= ICE_TX_DESC_CMD_IIPT_IPV6;
> > - *td_offset |= (tx_offload.l3_len >> 2) <<
> > - ICE_TX_DESC_LEN_IPLEN_S;
> > - }
> > + if (ol_flags & RTE_MBUF_F_TX_IP_CKSUM) {
> > + *td_cmd |= ICE_TX_DESC_CMD_IIPT_IPV4_CSUM;
> > + *td_offset |= (tx_offload.l3_len >> 2) <<
> > + ICE_TX_DESC_LEN_IPLEN_S;
> > + } else if (ol_flags & RTE_MBUF_F_TX_IPV4) {
> > + *td_cmd |= ICE_TX_DESC_CMD_IIPT_IPV4;
> > + *td_offset |= (tx_offload.l3_len >> 2) <<
> > + ICE_TX_DESC_LEN_IPLEN_S;
> > + } else if (ol_flags & RTE_MBUF_F_TX_IPV6) {
> > + *td_cmd |= ICE_TX_DESC_CMD_IIPT_IPV6;
> > + *td_offset |= (tx_offload.l3_len >> 2) <<
> > + ICE_TX_DESC_LEN_IPLEN_S;
> > }
> >
> > if (ol_flags & RTE_MBUF_F_TX_TCP_SEG) { diff --git
> > a/drivers/net/ice/ice_rxtx_vec_common.h
> > b/drivers/net/ice/ice_rxtx_vec_common.h
> > index 8ff01046e1..2dd2d83650 100644
> > --- a/drivers/net/ice/ice_rxtx_vec_common.h
> > +++ b/drivers/net/ice/ice_rxtx_vec_common.h
> > @@ -250,7 +250,8 @@ ice_rxq_vec_setup_default(struct ice_rx_queue *rxq)
> > #define ICE_TX_NO_VECTOR_FLAGS ( \
> > RTE_ETH_TX_OFFLOAD_MULTI_SEGS | \
> > RTE_ETH_TX_OFFLOAD_OUTER_IPV4_CKSUM | \
> > - RTE_ETH_TX_OFFLOAD_TCP_TSO)
> > + RTE_ETH_TX_OFFLOAD_TCP_TSO | \
> > + RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM)
> >
> > #define ICE_TX_VECTOR_OFFLOAD ( \
> > RTE_ETH_TX_OFFLOAD_VLAN_INSERT | \
> > @@ -364,45 +365,23 @@ ice_txd_enable_offload(struct rte_mbuf *tx_pkt,
> > uint32_t td_offset = 0;
> >
> > /* Tx Checksum Offload */
> > - /*Tunnel package usage outer len enable L2/L3 checksum offload*/
> > - if (ol_flags & RTE_MBUF_F_TX_TUNNEL_MASK) {
> > - /* SET MACLEN */
> > - td_offset |= (tx_pkt->outer_l2_len >> 1) <<
> > - ICE_TX_DESC_LEN_MACLEN_S;
> > -
> > - /* Enable L3 checksum offload */
> > - if (ol_flags & RTE_MBUF_F_TX_IP_CKSUM) {
> > - td_cmd |= ICE_TX_DESC_CMD_IIPT_IPV4_CSUM;
> > - td_offset |= (tx_pkt->outer_l3_len >> 2) <<
> > - ICE_TX_DESC_LEN_IPLEN_S;
> > - } else if (ol_flags & RTE_MBUF_F_TX_IPV4) {
> > - td_cmd |= ICE_TX_DESC_CMD_IIPT_IPV4;
> > - td_offset |= (tx_pkt->outer_l3_len >> 2) <<
> > - ICE_TX_DESC_LEN_IPLEN_S;
> > - } else if (ol_flags & RTE_MBUF_F_TX_IPV6) {
> > - td_cmd |= ICE_TX_DESC_CMD_IIPT_IPV6;
> > - td_offset |= (tx_pkt->outer_l3_len >> 2) <<
> > - ICE_TX_DESC_LEN_IPLEN_S;
> > - }
> > - } else {
> > - /* SET MACLEN */
> > - td_offset |= (tx_pkt->l2_len >> 1) <<
> > - ICE_TX_DESC_LEN_MACLEN_S;
> > -
> > - /* Enable L3 checksum offload */
> > - if (ol_flags & RTE_MBUF_F_TX_IP_CKSUM) {
> > - td_cmd |= ICE_TX_DESC_CMD_IIPT_IPV4_CSUM;
> > - td_offset |= (tx_pkt->l3_len >> 2) <<
> > - ICE_TX_DESC_LEN_IPLEN_S;
> > - } else if (ol_flags & RTE_MBUF_F_TX_IPV4) {
> > - td_cmd |= ICE_TX_DESC_CMD_IIPT_IPV4;
> > - td_offset |= (tx_pkt->l3_len >> 2) <<
> > - ICE_TX_DESC_LEN_IPLEN_S;
> > - } else if (ol_flags & RTE_MBUF_F_TX_IPV6) {
> > - td_cmd |= ICE_TX_DESC_CMD_IIPT_IPV6;
> > - td_offset |= (tx_pkt->l3_len >> 2) <<
> > - ICE_TX_DESC_LEN_IPLEN_S;
> > - }
> > + /* SET MACLEN */
> > + td_offset |= (tx_pkt->l2_len >> 1) <<
> > + ICE_TX_DESC_LEN_MACLEN_S;
> > +
> > + /* Enable L3 checksum offload */
> > + if (ol_flags & RTE_MBUF_F_TX_IP_CKSUM) {
> > + td_cmd |= ICE_TX_DESC_CMD_IIPT_IPV4_CSUM;
> > + td_offset |= (tx_pkt->l3_len >> 2) <<
> > + ICE_TX_DESC_LEN_IPLEN_S;
> > + } else if (ol_flags & RTE_MBUF_F_TX_IPV4) {
> > + td_cmd |= ICE_TX_DESC_CMD_IIPT_IPV4;
> > + td_offset |= (tx_pkt->l3_len >> 2) <<
> > + ICE_TX_DESC_LEN_IPLEN_S;
> > + } else if (ol_flags & RTE_MBUF_F_TX_IPV6) {
> > + td_cmd |= ICE_TX_DESC_CMD_IIPT_IPV6;
> > + td_offset |= (tx_pkt->l3_len >> 2) <<
> > + ICE_TX_DESC_LEN_IPLEN_S;
> > }
> >
> > /* Enable L4 checksum offloads */
> > --
> > 2.33.1
>
> Acked-by: Ting Xu <ting.xu@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
next prev parent reply other threads:[~2022-03-04 3:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-24 15:09 [PATCH] net/ice: fix Tx offload path choice Kevin Liu
2021-12-29 9:37 ` [PATCH v2 0/2] fix udp checksum error Kevin Liu
2021-12-29 9:37 ` [PATCH v2 1/2] net/ice: fix Tx offload path choice Kevin Liu
2022-03-04 3:19 ` Xu, Ting
2022-03-04 3:31 ` Zhang, Qi Z [this message]
2022-03-04 11:52 ` Ferruh Yigit
2021-12-29 9:37 ` [PATCH v2 2/2] app/testpmd: fix SW L4 checksum in multi-segments Kevin Liu
[not found] ` <d2d97e6cf1a14faaa47b61b63ed55573@intel.com>
2022-03-03 6:29 ` Zhang, Yuying
2022-03-11 7:04 ` Liu, KevinX
2022-03-11 8:02 ` Singh, Aman Deep
2022-03-11 8:12 ` Liu, KevinX
2022-03-11 9:04 ` Singh, Aman Deep
2022-03-11 10:46 ` Ferruh Yigit
2022-03-14 2:33 ` Zhang, Qi Z
2022-03-14 20:21 ` Thomas Monjalon
2022-03-02 8:56 ` [PATCH v2 0/2] fix udp checksum error Huang, ZhiminX
2022-02-24 2:32 ` [PATCH] net/ice: fix Tx offload path choice Ling, WeiX
2022-02-27 6:19 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=894899b025bc41a29aeff249740a7f92@intel.com \
--to=qi.z.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=kevinx.liu@intel.com \
--cc=qiming.yang@intel.com \
--cc=stable@dpdk.org \
--cc=stevex.yang@intel.com \
--cc=ting.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.