From mboxrd@z Thu Jan  1 00:00:00 1970
From: Xose Vazquez Perez <xose.vazquez@gmail.com>
Subject: Re: [PATCH] multipath-tools: reorder NVDISK devices
Date: Mon, 19 Aug 2019 17:45:42 +0200
Message-ID: <894a30db-0af2-6598-e37e-26617ff2b3ea@gmail.com>
References: <20190801172138.15049-1-xose.vazquez@gmail.com>
	<20190814154111.GE25414@octiron.msp.redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dm-devel-bounces@redhat.com>
In-Reply-To: <20190814154111.GE25414@octiron.msp.redhat.com>
Content-Language: en-GB
List-Unsubscribe: <https://www.redhat.com/mailman/options/dm-devel>,
	<mailto:dm-devel-request@redhat.com?subject=unsubscribe>
List-Archive: <https://www.redhat.com/archives/dm-devel>
List-Post: <mailto:dm-devel@redhat.com>
List-Help: <mailto:dm-devel-request@redhat.com?subject=help>
List-Subscribe: <https://www.redhat.com/mailman/listinfo/dm-devel>,
	<mailto:dm-devel-request@redhat.com?subject=subscribe>
Sender: dm-devel-bounces@redhat.com
Errors-To: dm-devel-bounces@redhat.com
To: Benjamin Marzinski <bmarzins@redhat.com>, Brian King <brking@linux.vnet.ibm.com>, DM-DEVEL ML <dm-devel@redhat.com>, Christophe Varoqui <christophe.varoqui@opensvc.com>
List-Id: dm-devel.ids

On 8/14/19 5:41 PM, Benjamin Marzinski wrote:

> On Thu, Aug 01, 2019 at 07:21:38PM +0200, Xose Vazquez Perez wrote:
>> Otherwise "3303[ ]+NVDISK" is never reached, because "NVDISK" regex takes
>> priority over it.
> 
> Huh? I don't understand why this is necessary. First off, with Martin's
> hwentry code, all matching hardware entries are used, not just the
> latest. But second, and more importantly, the AIX NVDISK entry won't
> ever match the same disks as the IBM 3303[ ]+NVDISK, since they have
> different vendors.  Right?

Yes, you are right. I mixed badly IBM-AIX in my head.

I'm sorry for the noise.

Christophe, remove this patch from your queue.


Thanks.

>> Cc: Brian King <brking@linux.vnet.ibm.com>
>> Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
>> Cc: DM-DEVEL ML <dm-devel@redhat.com>
>> Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
>> ---
>>  libmultipath/hwtable.c | 12 ++++++------
>>  1 file changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
>> index a06872e..8209554 100644
>> --- a/libmultipath/hwtable.c
>> +++ b/libmultipath/hwtable.c
>> @@ -696,12 +696,6 @@ static struct hwentry default_hw[] = {
>>  		.pgpolicy      = MULTIBUS,
>>  		.no_path_retry = (300 / DEFAULT_CHECKINT),
>>  	},
>> -	{
>> -		/* 3303 NVDISK */
>> -		.vendor        = "IBM",
>> -		.product       = "3303[ ]+NVDISK",
>> -		.no_path_retry = (300 / DEFAULT_CHECKINT),
>> -	},
>>  	{
>>  		/* AIX NVDISK */
>>  		.vendor        = "AIX",
>> @@ -712,6 +706,12 @@ static struct hwentry default_hw[] = {
>>  		.no_path_retry = (300 / DEFAULT_CHECKINT),
>>  		.prio_name     = PRIO_ALUA,
>>  	},
>> +	{
>> +		/* 3303 NVDISK */
>> +		.vendor        = "IBM",
>> +		.product       = "3303[ ]+NVDISK",
>> +		.no_path_retry = (300 / DEFAULT_CHECKINT),
>> +	},
>>          /*
>>           * Lenovo
>>           */
>> -- 
>> 2.21.0
>>
>> --
>> dm-devel mailing list
>> dm-devel@redhat.com
>> https://www.redhat.com/mailman/listinfo/dm-devel
>