From: Thomas Monjalon <thomas@monjalon.net>
To: Ray Kinsella <mdr@ashroe.eu>
Cc: Neil Horman <nhorman@tuxdriver.com>,
Akhil Goyal <akhil.goyal@nxp.com>,
Konstantin Ananyev <konstantin.ananyev@intel.com>,
Abhinandan Gujjar <abhinandan.gujjar@intel.com>,
dev@dpdk.org, david.marchand@redhat.com
Subject: Re: [dpdk-dev] [PATCH v1] devtools: update abi ignore for cryptodev
Date: Tue, 26 Jan 2021 12:55:40 +0100 [thread overview]
Message-ID: <89537896.31c7qgZWaZ@thomas> (raw)
In-Reply-To: <20210120142558.4120552-1-mdr@ashroe.eu>
20/01/2021 15:25, Ray Kinsella:
> Update the ignore entry for crytodev to use named fields instead of
> bit positions.
>
> Fixes: 1c3ffb9559
>
> Signed-off-by: Ray Kinsella <mdr@ashroe.eu>
> ---
> --- a/devtools/libabigail.abignore
> +++ b/devtools/libabigail.abignore
> @@ -15,4 +15,4 @@
> ; Ignore fields inserted in cacheline boundary of rte_cryptodev
> [suppress_type]
> name = rte_cryptodev
> - has_data_member_inserted_between = {0, 1023}
> + has_data_member_inserted_between = {offset_after(attached), end}
Adding a bit more explanations in the commit message:
It is allowing changes between the last field (attached) in ABI 21.0,
and the end of the padded struct in ABI 21.
Fixes: 1c3ffb95595e ("cryptodev: add enqueue and dequeue callbacks")
Acked-by: Thomas Monjalon <thomas@monjalon.net>
Applied, thanks.
prev parent reply other threads:[~2021-01-26 11:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-20 14:25 [dpdk-dev] [PATCH v1] devtools: update abi ignore for cryptodev Ray Kinsella
2021-01-20 15:41 ` Thomas Monjalon
2021-01-21 15:15 ` Dodji Seketeli
2021-01-21 15:58 ` Thomas Monjalon
2021-01-22 12:11 ` Kinsella, Ray
2021-01-22 13:09 ` Dodji Seketeli
2021-01-22 13:12 ` Kinsella, Ray
2021-01-24 11:58 ` Dodji Seketeli
2021-01-26 11:55 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89537896.31c7qgZWaZ@thomas \
--to=thomas@monjalon.net \
--cc=abhinandan.gujjar@intel.com \
--cc=akhil.goyal@nxp.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=mdr@ashroe.eu \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.