All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mimi Zohar <zohar@linux.ibm.com>
To: Eric Biggers <ebiggers@kernel.org>, linux-fscrypt@vger.kernel.org
Cc: linux-integrity@vger.kernel.org
Subject: Re: [PATCH] fsverity: simplify fsverity_get_digest()
Date: Tue, 29 Nov 2022 06:32:45 -0500	[thread overview]
Message-ID: <895c5afca8f2f39b60b87377c6817ce4eccb1f92.camel@linux.ibm.com> (raw)
In-Reply-To: <20221129045139.69803-1-ebiggers@kernel.org>

On Mon, 2022-11-28 at 20:51 -0800, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
> 
> Instead of looking up the algorithm by name in hash_algo_name[] to get
> its hash_algo ID, just store the hash_algo ID in the fsverity_hash_alg
> struct.  Verify at build time that every fsverity_hash_alg has a valid
> hash_algo ID with matching digest size.
> 
> Remove an unnecessary memset() of the whole digest array to 0 before the
> digest is copied into it.
> 
> Finally, remove the pr_debug statement.  There is already a pr_debug for
> the fsverity digest when the file is opened.
> 
> Signed-off-by: Eric Biggers <ebiggers@google.com>

Agreed, much simpler. 
   Reviewed-by: Mimi Zohar <zohar@linux.ibm.com>


      parent reply	other threads:[~2022-11-29 11:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-29  4:51 [PATCH] fsverity: simplify fsverity_get_digest() Eric Biggers
2022-11-29  5:06 ` Eric Biggers
2022-11-29 11:32 ` Mimi Zohar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=895c5afca8f2f39b60b87377c6817ce4eccb1f92.camel@linux.ibm.com \
    --to=zohar@linux.ibm.com \
    --cc=ebiggers@kernel.org \
    --cc=linux-fscrypt@vger.kernel.org \
    --cc=linux-integrity@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.