From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] scripts: check commit formatting
Date: Mon, 11 Apr 2016 12:00:05 +0200
Message-ID: <8960252.5hA2CMWBcp@xps13>
References: <1459286986-31148-1-git-send-email-thomas.monjalon@6wind.com>
 <20160330014634.GC3080@yliu-dev.sh.intel.com>
 <20160330142740.GB21156@bricha3-MOBL3>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Bruce Richardson <bruce.richardson@intel.com>,
 Yuanhan Liu <yuanhan.liu@linux.intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50])
 by dpdk.org (Postfix) with ESMTP id 5D0E22B89
 for <dev@dpdk.org>; Mon, 11 Apr 2016 12:00:07 +0200 (CEST)
Received: by mail-wm0-f50.google.com with SMTP id a140so5709662wma.0
 for <dev@dpdk.org>; Mon, 11 Apr 2016 03:00:07 -0700 (PDT)
In-Reply-To: <20160330142740.GB21156@bricha3-MOBL3>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-03-30 15:27, Bruce Richardson:
> On Wed, Mar 30, 2016 at 09:46:34AM +0800, Yuanhan Liu wrote:
> > On Tue, Mar 29, 2016 at 11:29:46PM +0200, Thomas Monjalon wrote:
> > > The git messages have three parts:
> > > 1/ the headline
> > > 2/ the explanations
> > > 3/ the footer tags
> > > 
> > > The headline helps to quickly browse an history or catch instantly the
> > > purpose of a commit. Making it short with some consistent wording
> > > allows to easily parse it or match some patterns.
> > > 
> > > The explanations must give some keys like the reason of the change.
> > > Nothing can be automatically checked for this part.
> > 
> > Actually, I think we might be able to do 2 tests here:
> > 
> > - space line between paragraphs.
> > 
> > - lines over 80 chars.
> 
> 75 chars for commit messages, and 50 for commit titles :-)

The 75 chars limit is already checked by checkpatch.pl.
But yes we can have our own check in this script.

For the title, I think we can accept 60 chars and exceptionnaly more.

To see the history of title length:
	git log --format='%s' |
	awk '{lens[length($0)]++;} END {for (len in lens) print len, lens[len] }' |
	sort -g