From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Rob Clark <robdclark@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/5] drm/cma: use correct fb width/height
Date: Sat, 07 Mar 2015 19:56:33 +0200 [thread overview]
Message-ID: <8968992.QQbB6CNqx2@avalon> (raw)
In-Reply-To: <1425676990-14341-2-git-send-email-robdclark@gmail.com>
Hi Rob,
Thank you for the patch.
On Friday 06 March 2015 16:23:06 Rob Clark wrote:
This deserves an explanation, the reason why this fix is needed is far from
clear from the code only.
> Signed-off-by: Rob Clark <robdclark@gmail.com>
> ---
> drivers/gpu/drm/drm_fb_cma_helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c
> b/drivers/gpu/drm/drm_fb_cma_helper.c index cc0ae04..5c1aca4 100644
> --- a/drivers/gpu/drm/drm_fb_cma_helper.c
> +++ b/drivers/gpu/drm/drm_fb_cma_helper.c
> @@ -304,7 +304,7 @@ static int drm_fbdev_cma_create(struct drm_fb_helper
> *helper, }
>
> drm_fb_helper_fill_fix(fbi, fb->pitches[0], fb->depth);
> - drm_fb_helper_fill_var(fbi, helper, fb->width, fb->height);
> + drm_fb_helper_fill_var(fbi, helper, sizes->fb_width, sizes->fb_height);
>
> offset = fbi->var.xoffset * bytes_per_pixel;
> offset += fbi->var.yoffset * fb->pitches[0];
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-03-07 17:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-06 21:23 [PATCH 0/5] drm/fb: handle tile connectors Rob Clark
2015-03-06 21:23 ` [PATCH 1/5] drm/cma: use correct fb width/height Rob Clark
2015-03-07 17:56 ` Laurent Pinchart [this message]
2015-03-07 18:35 ` Rob Clark
2015-03-06 21:23 ` [PATCH 2/5] drm/exynos: " Rob Clark
2015-03-11 13:35 ` Inki Dae
2015-03-06 21:23 ` [PATCH 3/5] drm/rockchip: " Rob Clark
2015-03-06 21:23 ` [PATCH 4/5] drm/fb: small cleanup Rob Clark
2015-03-07 6:21 ` Daniel Kurtz
2015-03-06 21:23 ` [PATCH 5/5] drm/fb: handle tiled connectors better Rob Clark
2015-03-07 13:48 ` Rob Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8968992.QQbB6CNqx2@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=robdclark@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.