All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: "John W. Linville" <linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH] librte_pmd_af_packet: add compile-time checks for kernel-specific options
Date: Fri, 05 Dec 2014 10:30:53 +0100	[thread overview]
Message-ID: <8974312.4KPnm9h9PX@xps13> (raw)
In-Reply-To: <1417729325-9410-1-git-send-email-linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>

Hi John,

2014-12-04 16:42, John W. Linville:
> This allows the PMD to compile with kernels that don't support the
> options in question.  The "#if defined(...)" lines are a bit ugly,
> but I don't know of any better way to accomplish the task.
> 
> Signed-off-by: John W. Linville <linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
> ---
>  lib/librte_pmd_af_packet/rte_eth_af_packet.c | 16 ++++++++++++----
>  1 file changed, 12 insertions(+), 4 deletions(-)

Is it possible to enable compilation of this PMD in default configuration?
I guess it shouldn't fail anymore with this patch?

-- 
Thomas

  parent reply	other threads:[~2014-12-05  9:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-04 21:42 [PATCH] librte_pmd_af_packet: add compile-time checks for kernel-specific options John W. Linville
     [not found] ` <1417729325-9410-1-git-send-email-linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2014-12-05  3:46   ` Neil Horman
2014-12-05  9:30   ` Thomas Monjalon [this message]
2014-12-05 16:24     ` John W. Linville
     [not found]       ` <20141205162453.GB28319-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2014-12-05 16:37         ` Thomas Monjalon
2014-12-05 17:29           ` Accessing Virtual Function Device on Guest Machine using VFIO Aashima Arora
     [not found]             ` <ba8c3baac3b4430dac0f007f6da0c564-AcH5Oudqfb99HHjWtI06IMyo0RDPibkP@public.gmane.org>
2014-12-05 18:08               ` Thomas Monjalon
2014-12-05 18:42                 ` Neil Horman
2014-12-05 21:14           ` [PATCH] librte_pmd_af_packet: add compile-time checks for kernel-specific options Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8974312.4KPnm9h9PX@xps13 \
    --to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
    --cc=dev-VfR2kkLFssw@public.gmane.org \
    --cc=linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.