From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8294C1C0DE6 for ; Thu, 30 May 2024 12:17:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717071460; cv=none; b=NiNIvbAtuGF/SwPrPYq2G0gt4c0yZnqpTWwPzlkXnzyxTlYfatJWrzclHNWnhh0MqKjttif5g6mdkGUMVvbEtgyTQrHnkS5FfPmzC5hWZcTevWA726/BOyMNE3PJBD4dpljqUaN00PKI6XoQeRnw6jDBEXxek7By9Dy/NmaYg1E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717071460; c=relaxed/simple; bh=V5hI7KMkzgVk/ALuPDZUKKRsX7oat0m5/GaY+dT+YqQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=nsmpRG1FwPtWnUDA8IvNpY3m67kCiRXk4gwtbgqgdyOvgCEiIRaZMCef32Iak1zDe+vnz6bUKOHo0A9nth6gQSxQXOfL09AzTNc+him43SMIYobgru+gMGHLlRnSu64qyu6ijy0rpFdJAeGyDidtGntbXNt8UnzpY8d48cW0Hts= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Ql48ey4Q; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Ql48ey4Q" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1717071458; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UMT67zC+fbo2iQB9ZfpmsekE+SDPWB6XReNKWdjTg/c=; b=Ql48ey4QhicKWxG+D5Q/WvuCK4nnqRaKePjP4AWTxtz9i0nGGyLTRV0pE8rkxFAhjFbI7A eSWGumUm7lStyVl2cmu0RhmM9mREJmbbOOIA6oQZcFu/yS4JQPTRFYsj7JBu5Z3cJkQXqk p7diNOYvYslSHccrMdlvqQdQaVnXenI= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-231-m6wUiO5EOzStcTvpRDWukA-1; Thu, 30 May 2024 08:17:37 -0400 X-MC-Unique: m6wUiO5EOzStcTvpRDWukA-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-354f31fbe0bso706800f8f.0 for ; Thu, 30 May 2024 05:17:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717071456; x=1717676256; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UMT67zC+fbo2iQB9ZfpmsekE+SDPWB6XReNKWdjTg/c=; b=PEtf0wYjPF+ug19RgYpGfm6O4RLbRiGeGsKoMT60mMN4NxohtDGNP4bFguYBHGSZjS CC5zZXpg8wLkHMgU5POJLk8oZx5rZFMEySoHkL9RRg5DgNPDiyYp694XmVK6w9C6kZJJ 3JZEynnD4HGXHcjZDymMhy6nrNTHQ+L0YfGiyRT80M8lNVLi6MfWEvZj+Wulgvkz6rFb 9Jydn9IA1gC140rhgIl5+OruqKXzHd5YGZeCHaKcr7MQxAwNeXPJIAmWIya85/fOocyr XN+8SfwdMMnynzpyJtfjxh8Xe23pw8NNvS4Yh2I1JX/DrvK6IGu/WnrHmCQSiTpgDxi5 3Zlw== X-Forwarded-Encrypted: i=1; AJvYcCVk0Lf0o+4aWT7XJuplc3poCLbQsRte7B4lykaoSSEjW1wuZcHcudQLImrHxyVLMEYmSgvrLx6eN9FPIHI1d5Fxfsc0CDrR X-Gm-Message-State: AOJu0Yxtpu+MtjCrFMSSrpRNg8Xkaz74tuQqCT1MGILxyc4Z5LMTC7DA 12ems81WMqzof5mwuW0ylgnaL5HL+oThXhrxdqkm88FPSe0Xwh+dWXoOSdK07kcgNqXj/sitToy r1RiHqjmT8Y6oEfTlB0tmHqb/8c5RuY26It3w738taZ6v4FX+o635GQ== X-Received: by 2002:adf:f989:0:b0:354:f90c:63dd with SMTP id ffacd0b85a97d-35dc00369c3mr1370854f8f.0.1717071456020; Thu, 30 May 2024 05:17:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGCeaFufh+CD65vlqUrpverwcUO7ViCXf3RbM0I0lK+Q3pHJBTo8PrCVYwi3ANZO5WJqWE20A== X-Received: by 2002:adf:f989:0:b0:354:f90c:63dd with SMTP id ffacd0b85a97d-35dc00369c3mr1370836f8f.0.1717071455558; Thu, 30 May 2024 05:17:35 -0700 (PDT) Received: from ?IPV6:2a01:e0a:59e:9d80:527b:9dff:feef:3874? ([2a01:e0a:59e:9d80:527b:9dff:feef:3874]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-35dca3dbee6sm1356852f8f.53.2024.05.30.05.17.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 May 2024 05:17:35 -0700 (PDT) Message-ID: <897ea2fa-838a-4b33-8434-dba5dddaf9ca@redhat.com> Date: Thu, 30 May 2024 14:17:33 +0200 Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/6] KVM: arm64: maintain per VM value for CTR_EL0 To: Sebastian Ott Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Catalin Marinas , Will Deacon References: <20240514072252.5657-1-sebott@redhat.com> <20240514072252.5657-3-sebott@redhat.com> <90e53cc7-039f-5abc-f94c-cf53a1602a2a@redhat.com> <2dcfc174-9384-4746-833d-1442bcfb6d11@redhat.com> From: Eric Auger In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 5/30/24 13:24, Sebastian Ott wrote: > On Wed, 29 May 2024, Eric Auger wrote: >> On 5/29/24 17:51, Sebastian Ott wrote: >>> On Wed, 29 May 2024, Eric Auger wrote: >>>>> @@ -3557,6 +3557,13 @@ void kvm_reset_sys_regs(struct kvm_vcpu *vcpu) >>>>>      struct kvm *kvm = vcpu->kvm; >>>>>      unsigned long i; >>>>> >>>>> +    if (!kvm_vcpu_initialized(vcpu)) >>>> at this stage of the reading, why is the above check needed? >>> >>> To make sure that a later call to this function doesn't overwrite >>> the value provided by userspace. (See e016333745c "KVM: arm64: Only >>> reset vCPU-scoped feature ID regs once"). >> but isn't it overwritten through the .reset=reset_ctr() that is >> populated in next patch? > > No, this is done via reset_vcpu_ftr_id_reg() and also guarded by > kvm_vcpu_initialized(). OK thanks. Eric > > Sebastian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 47A2FC25B74 for ; Thu, 30 May 2024 12:18:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=N3/tszzrwsf+BGTmnW4BX2NMA5cIpWPD7BbgJTEnSvY=; b=sMG8BfRJS7jvjl aPDRbAW+uDqoFe5Y14zb1ZNMqMwFNCiWpSW/CkuEiqsgjzIb8/BnjnF+ssAMj9W6oobqu+lmWRxzE 6x3Ht9XnWj/PVDbmt9mZ5BMNaxyOSzcS/xLfsPcSEbBNAXw9to4tm/lMyRdsknC/Ol++To9RIOOWn 5NKpkPqoxNLtv0N435XMmG38oX4nq1k7C+pix27n0s9OlkeTJr7nlyKFgiaeCIaswI0vTaZ1KjH48 Jta4WTzcDhpkAI9CRMaAILLnqEDkdxUS2I0iHC2JRS/beiMcgXnC09aZNPX0C55G3fRykaiP77Svg sBEAUG4ykOtZz8b0gFEA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sCej4-00000007CRh-1wi1; Thu, 30 May 2024 12:17:46 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sCej2-00000007CRF-1yVf for linux-arm-kernel@lists.infradead.org; Thu, 30 May 2024 12:17:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1717071460; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UMT67zC+fbo2iQB9ZfpmsekE+SDPWB6XReNKWdjTg/c=; b=LoAwMDxVHuQKj/WF4jyOSj/tx2lnxHbSKNZT0LpG5s9N1EiAeaBjln1b4wsQlZvraXCwhx 9X9vMLJQ45ZOSNG+OvBSb7FdaR+Y/wf79kRCymuJguZwMwdo8CwIKAtIHAquEIaD/Agd8I 8l0Fiwbvh8zaf1o1GfDy2BbOOaNowxk= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-678-AapmcsyjOiKJ_mstoMt1WA-1; Thu, 30 May 2024 08:17:37 -0400 X-MC-Unique: AapmcsyjOiKJ_mstoMt1WA-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-357766bb14fso583607f8f.2 for ; Thu, 30 May 2024 05:17:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717071456; x=1717676256; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UMT67zC+fbo2iQB9ZfpmsekE+SDPWB6XReNKWdjTg/c=; b=R23v1nRjVCffF+ekunMSI/QZ7ZwcvGcIDNc0vP3clFb6MZ59pT8hgX/VqCZ9tIP6HW qlH2Ubt8Nn88oVZ8dp0/dod57BdFDhl3m+GDPQ8BDJzZKklAanxBptY7Sd+T9K4TDqV8 p4E1Vh+05tm74mk75xebadl7BRwnEUccwy1kkvvEFOpdS7uAcReJcQh4CjfspIXbRFFW SCcAvwO1qp4sP666PTHg0NCIM9NB/VN/ZhvWsXjWYlqn8IeYx2r7GbMkD3aSnNVWdWS5 O8azLaLw+BsmljI5vFfQcGqLTVmmELW3c3TNeKI8bMog7lVPhafRPLSDPRuZ/nr1uQHw 2txA== X-Gm-Message-State: AOJu0YxNG6NNAtWPSrUud9roY+lTCUa/VOd1p7twNUUgucuoFeInK/G8 tGA7ugV0SqMzchTygJb4lPfVAHwB4HLxD9kXOMD4K9H+mQtNyUAXhQHhYTdcM19+Aafc8cB0umf 7TF4pnRj8D0nF1uaELHP89u814Dk51VIdYYk4lGtzfFWZr6uKYUfye21unIIYP+IafjuMRk2R X-Received: by 2002:adf:f989:0:b0:354:f90c:63dd with SMTP id ffacd0b85a97d-35dc00369c3mr1370864f8f.0.1717071456069; Thu, 30 May 2024 05:17:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGCeaFufh+CD65vlqUrpverwcUO7ViCXf3RbM0I0lK+Q3pHJBTo8PrCVYwi3ANZO5WJqWE20A== X-Received: by 2002:adf:f989:0:b0:354:f90c:63dd with SMTP id ffacd0b85a97d-35dc00369c3mr1370836f8f.0.1717071455558; Thu, 30 May 2024 05:17:35 -0700 (PDT) Received: from ?IPV6:2a01:e0a:59e:9d80:527b:9dff:feef:3874? ([2a01:e0a:59e:9d80:527b:9dff:feef:3874]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-35dca3dbee6sm1356852f8f.53.2024.05.30.05.17.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 May 2024 05:17:35 -0700 (PDT) Message-ID: <897ea2fa-838a-4b33-8434-dba5dddaf9ca@redhat.com> Date: Thu, 30 May 2024 14:17:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/6] KVM: arm64: maintain per VM value for CTR_EL0 To: Sebastian Ott Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Catalin Marinas , Will Deacon References: <20240514072252.5657-1-sebott@redhat.com> <20240514072252.5657-3-sebott@redhat.com> <90e53cc7-039f-5abc-f94c-cf53a1602a2a@redhat.com> <2dcfc174-9384-4746-833d-1442bcfb6d11@redhat.com> From: Eric Auger In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240530_051744_663839_4CDF1332 X-CRM114-Status: GOOD ( 10.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org CgpPbiA1LzMwLzI0IDEzOjI0LCBTZWJhc3RpYW4gT3R0IHdyb3RlOgo+IE9uIFdlZCwgMjkgTWF5 IDIwMjQsIEVyaWMgQXVnZXIgd3JvdGU6Cj4+IE9uIDUvMjkvMjQgMTc6NTEsIFNlYmFzdGlhbiBP dHQgd3JvdGU6Cj4+PiBPbiBXZWQsIDI5IE1heSAyMDI0LCBFcmljIEF1Z2VyIHdyb3RlOgo+Pj4+ PiBAQCAtMzU1Nyw2ICszNTU3LDEzIEBAIHZvaWQga3ZtX3Jlc2V0X3N5c19yZWdzKHN0cnVjdCBr dm1fdmNwdSAqdmNwdSkKPj4+Pj4gwqDCoMKgwqAgc3RydWN0IGt2bSAqa3ZtID0gdmNwdS0+a3Zt Owo+Pj4+PiDCoMKgwqDCoCB1bnNpZ25lZCBsb25nIGk7Cj4+Pj4+Cj4+Pj4+ICvCoMKgwqAgaWYg KCFrdm1fdmNwdV9pbml0aWFsaXplZCh2Y3B1KSkKPj4+PiBhdCB0aGlzIHN0YWdlIG9mIHRoZSBy ZWFkaW5nLCB3aHkgaXMgdGhlIGFib3ZlIGNoZWNrIG5lZWRlZD8KPj4+Cj4+PiBUbyBtYWtlIHN1 cmUgdGhhdCBhIGxhdGVyIGNhbGwgdG8gdGhpcyBmdW5jdGlvbiBkb2Vzbid0IG92ZXJ3cml0ZQo+ Pj4gdGhlIHZhbHVlIHByb3ZpZGVkIGJ5IHVzZXJzcGFjZS4gKFNlZSBlMDE2MzMzNzQ1YyAiS1ZN OiBhcm02NDogT25seQo+Pj4gcmVzZXQgdkNQVS1zY29wZWQgZmVhdHVyZSBJRCByZWdzIG9uY2Ui KS4KPj4gYnV0IGlzbid0IGl0IG92ZXJ3cml0dGVuIHRocm91Z2ggdGhlIC5yZXNldD1yZXNldF9j dHIoKSB0aGF0IGlzCj4+IHBvcHVsYXRlZCBpbiBuZXh0IHBhdGNoPwo+IAo+IE5vLCB0aGlzIGlz IGRvbmUgdmlhIHJlc2V0X3ZjcHVfZnRyX2lkX3JlZygpIGFuZCBhbHNvIGd1YXJkZWQgYnkKPiBr dm1fdmNwdV9pbml0aWFsaXplZCgpLgoKT0sgdGhhbmtzLgoKRXJpYwo+IAo+IFNlYmFzdGlhbgoK Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFy bS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9y ZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1r ZXJuZWwK