From mboxrd@z Thu Jan  1 00:00:00 1970
From: Patrice CHOTARD <patrice.chotard@st.com>
Date: Mon, 15 May 2017 08:00:15 +0000
Subject: [U-Boot] [PATCH v2 4/5] usb: host: replace printf() by error()
 in ehci-generic
In-Reply-To: <3aa08585-ac59-2cd0-4cee-5b90eecc2225@denx.de>
References: <1494610077-21721-1-git-send-email-patrice.chotard@st.com>
 <1494610077-21721-5-git-send-email-patrice.chotard@st.com>
 <3aa08585-ac59-2cd0-4cee-5b90eecc2225@denx.de>
Message-ID: <898ebc8a-ec25-bb9f-bcb2-632574f87f34@st.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Marek

On 05/12/2017 10:51 PM, Marek Vasut wrote:
> On 05/12/2017 07:27 PM, patrice.chotard at st.com wrote:
>> From: Patrice Chotard <patrice.chotard@st.com>
>
> Commit message does not explain WHY this change is needed. In fact ...
> commit message is missing altogether ...

Yes, my bad i forget it, i will add it in the v3

Thanks

Patrice


>
>> Signed-off-by: Patrice Chotard <patrice.chotard@st.com>
>> ---
>>
>> v2:	_ create this independant path for printf() replacement
>>
>>  drivers/usb/host/ehci-generic.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/usb/host/ehci-generic.c b/drivers/usb/host/ehci-generic.c
>> index 0000808..39b56de 100644
>> --- a/drivers/usb/host/ehci-generic.c
>> +++ b/drivers/usb/host/ehci-generic.c
>> @@ -74,7 +74,7 @@ static int ehci_usb_probe(struct udevice *dev)
>>  		if (ret < 0)
>>  			break;
>>  		if (clk_enable(&clk)) {
>> -			printf("failed to enable clock %d\n", i);
>> +			error("failed to enable clock %d\n", i);
>>  			clk_free(&clk);
>>  			goto clk_err;
>>  		}
>> @@ -88,7 +88,7 @@ static int ehci_usb_probe(struct udevice *dev)
>>  		if (ret < 0)
>>  			break;
>>  		if (reset_deassert(&reset)) {
>> -			printf("failed to deassert reset %d\n", i);
>> +			error("failed to deassert reset %d\n", i);
>>  			reset_free(&reset);
>>  			goto reset_err;
>>  		}
>>
>
>