Re: [PATCH rtw-next 2/3] wifi: rtw88: report the frames purged from the TX report queue

[Luka Gejak <luka.gejak@linux.dev>]

On November 11, 2026 10:32:38 PM GMT+01:00, Mehmet Fide
<mehmet.fide@gmail.com> wrote:
>From: Mehmet Fide <mehmet.fide@screeningeagle.com>
>
>A frame whose sender asked for its TX status waits in the TX report
>queue for the report of the firmware. When no report comes, the purge
>timer frees the frames with skb_queue_purge(), and rtw_core_deinit()
>does the same. mac80211 is not told: the sender gets no status, and the
>copy mac80211 keeps for the status of a frame from user space stays in
>its list until ieee80211_free_hw() warns about it. On an RTL8822CE with
>hostapd, after a firmware crash and an unbind of the driver:
>
>rtw88_8822ce 0000:01:00.0: failed to get tx report from firmware
>[...]
>Have pending ack frames!
>WARNING: net/mac80211/main.c:1761 at ieee80211_free_ack_frame+0x4c/0x70 [mac80211], CPU#1: sh/24725
>Call trace:
> ieee80211_free_ack_frame+0x4c/0x70 [mac80211] (P)
> idr_for_each+0x6c/0xf4
> ieee80211_free_hw+0x30/0x8c [mac80211]
> rtw_pci_remove+0xd8/0xf0 [rtw88_pci]
> pci_device_remove+0x44/0xd4
>
>Take the frames off the queue under its lock and hand them to
>ieee80211_purge_tx_queue(), which reports each one as not sent.
>
>Fixes: e3037485c68e ("rtw88: new Realtek 802.11ac driver")
>Signed-off-by: Mehmet Fide <mehmet.fide@screeningeagle.com>
>---

Looks good to me,

Reviewed-by: Luka Gejak <luka.gejak@linux.dev>

Best regards,
Luka Gejak