From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Stephen Hemminger <stephen@networkplumber.org>, dev@dpdk.org
Subject: Re: [PATCH v2 1/3] test: remove some strings from cmdline_etheraddr tests
Date: Tue, 3 Oct 2023 11:59:04 +0100 [thread overview]
Message-ID: <89a6ef0b-1cbf-4ebf-b0d8-c900271152da@amd.com> (raw)
In-Reply-To: <d34aeba1-c57a-44f3-b8c7-65155154b4c7@amd.com>
On 10/3/2023 11:47 AM, Ferruh Yigit wrote:
> On 10/2/2023 7:37 PM, Stephen Hemminger wrote:
>> Some of the ethernet address formats which were invalid will
>> now become valid inputs when rte_ether_unformat_addr is modified
>> to allow leading zeros.
>>
>> Also, make local variables static.
>>
>> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>>
>
> <...>
>
>> @@ -61,10 +60,8 @@ const char * ether_addr_invalid_strs[] = {
>> "INVA:LIDC:HARS",
>> /* misc */
>> "01 23 45 67 89 AB",
>> - "01.23.45.67.89.AB",
>> "01,23,45,67,89,AB",
>> - "01:23:45\0:67:89:AB",
>> - "01:23:45#:67:89:AB",
>>
>
> Why these two are valid now?
>
> And I guess second one is still not valid, but first one is parsed as
> [1], is this expected?
>
> [1] 00:01:00:23:00:45
>
>
Ah, I guess it is taken as "XXXX:XXXX:XXXX" format, but number of digit
is not enforced, so "1:2:3" is a valid format, should we add this to API
documentation as example format? Or is this unintended side effect?
next prev parent reply other threads:[~2023-10-03 10:59 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-29 16:36 [RFC] rte_ether_unformat: accept more inputs Stephen Hemminger
2023-09-29 19:35 ` Morten Brørup
2023-09-29 23:08 ` Stephen Hemminger
2023-10-02 18:37 ` [PATCH v2 0/3] rte_ether_unformat_addr changes Stephen Hemminger
2023-10-02 18:37 ` [PATCH v2 1/3] test: remove some strings from cmdline_etheraddr tests Stephen Hemminger
2023-10-03 10:47 ` Ferruh Yigit
2023-10-03 10:59 ` Ferruh Yigit [this message]
2023-10-03 16:38 ` Stephen Hemminger
2023-10-03 16:36 ` Stephen Hemminger
2023-10-03 16:50 ` Ferruh Yigit
2023-10-03 17:18 ` Stephen Hemminger
2023-10-02 18:37 ` [PATCH v2 2/3] rte_ether_unformat: accept more inputs Stephen Hemminger
2023-10-02 18:37 ` [PATCH v2 3/3] test: add tests for rte_ether routines Stephen Hemminger
2023-10-03 6:17 ` [PATCH v2 0/3] rte_ether_unformat_addr changes Morten Brørup
2023-10-03 10:44 ` Ferruh Yigit
2023-10-03 16:27 ` Stephen Hemminger
2023-10-03 16:34 ` Stephen Hemminger
2023-10-03 20:29 ` [PATCH v3 0/4] rte_ether_unformat_addr related changes Stephen Hemminger
2023-10-03 20:29 ` [PATCH v3 1/4] test: remove some strings from cmdline_etheraddr tests Stephen Hemminger
2023-10-03 20:29 ` [PATCH v3 2/4] rte_ether_unformat: accept more inputs Stephen Hemminger
2023-10-03 20:29 ` [PATCH v3 3/4] test: add tests for rte_ether routines Stephen Hemminger
2023-10-03 20:29 ` [PATCH v3 4/4] net/tap: use rte_ether_unformat_address Stephen Hemminger
2023-10-11 14:25 ` Ferruh Yigit
2023-10-04 11:48 ` [PATCH v3 0/4] rte_ether_unformat_addr related changes Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89a6ef0b-1cbf-4ebf-b0d8-c900271152da@amd.com \
--to=ferruh.yigit@amd.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.