From: Richard GENOUD <richard.genoud@bootlin.com>
To: Kexin Sun <kexinsun@smail.nju.edu.cn>,
gregkh@linuxfoundation.org, jirislaby@kernel.org
Cc: nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com,
claudiu.beznea@tuxon.dev, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, julia.lawall@inria.fr,
xutong.ma@inria.fr, yunbolyu@smu.edu.sg, ratnadiraw@smu.edu.sg
Subject: Re: [PATCH v2] tty: atmel_serial: update outdated reference to atmel_tasklet_func()
Date: Tue, 24 Mar 2026 08:08:40 +0100 [thread overview]
Message-ID: <89bc9543-9fcb-4563-b6ff-01b186231ce8@bootlin.com> (raw)
In-Reply-To: <20260324024857.3244-1-kexinsun@smail.nju.edu.cn>
Le 24/03/2026 à 03:48, Kexin Sun a écrit :
> The modem-status comparison that used irq_status_prev was
> moved from atmel_tasklet_func() into atmel_handle_status() in
> commit d033e82db9a5 ("tty/serial: at91: handle IRQ status
> more safely"). Update the comment accordingly.
Double space here, but I don't think it's necessary to send another
iteration for that.
>
> Assisted-by: unnamed:deepseek-v3.2 coccinelle
> Signed-off-by: Kexin Sun <kexinsun@smail.nju.edu.cn>
Acked-by Richard Genoud <richard.genoud@bootlin.com>
> ---
> drivers/tty/serial/atmel_serial.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c
> index 08dd8f887956..5d8c1cfc1c60 100644
> --- a/drivers/tty/serial/atmel_serial.c
> +++ b/drivers/tty/serial/atmel_serial.c
> @@ -1927,7 +1927,7 @@ static int atmel_startup(struct uart_port *port)
> atmel_uart_writel(port, ATMEL_US_FMR, fmr);
> }
>
> - /* Save current CSR for comparison in atmel_tasklet_func() */
> + /* Save current CSR for comparison in atmel_handle_status() */
> atmel_port->irq_status_prev = atmel_uart_readl(port, ATMEL_US_CSR);
>
> /*
Thanks!
next prev parent reply other threads:[~2026-03-24 7:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-21 10:59 [PATCH] tty: atmel_serial: update outdated reference to atmel_tasklet_func() Kexin Sun
2026-03-23 9:29 ` Richard GENOUD
2026-03-24 2:48 ` [PATCH v2] " Kexin Sun
2026-03-24 7:08 ` Richard GENOUD [this message]
2026-03-24 7:58 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89bc9543-9fcb-4563-b6ff-01b186231ce8@bootlin.com \
--to=richard.genoud@bootlin.com \
--cc=alexandre.belloni@bootlin.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=julia.lawall@inria.fr \
--cc=kexinsun@smail.nju.edu.cn \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=ratnadiraw@smu.edu.sg \
--cc=xutong.ma@inria.fr \
--cc=yunbolyu@smu.edu.sg \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.