From: "Philippe Mathieu-Daudé" <philippe.mathieu.daude@gmail.com>
To: zhenwei pi <pizhenwei@bytedance.com>,
pbonzini@redhat.com, mst@redhat.com
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH 2/2] hw/misc/pvpanic: Use standard headers instead
Date: Mon, 21 Feb 2022 14:32:31 +0100 [thread overview]
Message-ID: <89be0672-87e4-b0dc-5b36-0ab05f100e8a@gmail.com> (raw)
In-Reply-To: <20220221122717.1371010-2-pizhenwei@bytedance.com>
On 21/2/22 13:27, zhenwei pi wrote:
> QEMU side has already imported pvpanic.h from linux, remove bit
> definitions from include/hw/misc/pvpanic.h, and use
> include/standard-headers/linux/pvpanic.h instead.
> Also minor changes for PVPANIC_CRASHLOADED -> PVPANIC_CRASH_LOADED.
It seems to fail to build, missing PVPANIC_CRASH_LOADED. On which
tree is this patch based?
Do we need to run scripts/update-linux-headers.sh before?
> Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
> ---
> hw/misc/pvpanic-isa.c | 4 +++-
> hw/misc/pvpanic-pci.c | 4 +++-
> hw/misc/pvpanic.c | 5 +++--
> include/hw/misc/pvpanic.h | 8 --------
> 4 files changed, 9 insertions(+), 12 deletions(-)
next prev parent reply other threads:[~2022-02-21 13:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-21 12:27 [PATCH 1/2] headers: Add pvpanic.h zhenwei pi
2022-02-21 12:27 ` [PATCH 2/2] hw/misc/pvpanic: Use standard headers instead zhenwei pi
2022-02-21 13:32 ` Philippe Mathieu-Daudé [this message]
2022-02-21 14:11 ` Peter Maydell
2022-02-21 14:29 ` Philippe Mathieu-Daudé
2022-02-21 15:10 ` [PATCH 1/2] headers: Add pvpanic.h Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89be0672-87e4-b0dc-5b36-0ab05f100e8a@gmail.com \
--to=philippe.mathieu.daude@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pizhenwei@bytedance.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.