Re: [PATCH] dt-bindings: input: Goodix SPI HID Touchscreen

[Krzysztof Kozlowski <krzk@kernel.org>]

On 19/10/2024 04:46, Charles Wang wrote:
>>>>> +  goodix,hid-report-addr:
>>>>> +    $ref: /schemas/types.yaml#/definitions/uint32
>>>>> +    description:
>>>>> +      The register address for retrieving HID report data.
>>>>> +      This address is related to the device firmware and may
>>>>> +      change after a firmware update.
>>>>
> 
>> How is this supposed to work? DTS will stay fixed, you cannot change it
>> just because firmware changed. User loads new firmware with different
>> address, but DTS will have to use old address - so broken property.
>>
> 
> Sorry for missing this issue in my previous response.
> Honestly, although the likelihood of this address changing is low, it is
> indeed possible for it to change due to a firmware update during the factory
> debugging phase. However, for machines that users have, we will ensure that
> this address will not be altered as a result of a firmware upgrade.

Then it feels like property is not really needed - all boards will have
exactly same value.

Best regards,
Krzysztof