From: Daniel Lezcano <daniel.lezcano@oss.qualcomm.com>
To: Caleb James DeLisle <cjd@cjdns.fr>, linux-mips@vger.kernel.org
Cc: naseefkm@gmail.com, daniel.lezcano@kernel.org, tglx@kernel.org,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] clocksource/timer-econet-en751221: Support irq number per timer
Date: Wed, 6 May 2026 17:39:40 +0200 [thread overview]
Message-ID: <89e792f3-3a8d-424f-abe4-b915bee63265@oss.qualcomm.com> (raw)
In-Reply-To: <b37dd665-3d25-4627-ab04-17431d9931f4@cjdns.fr>
On 5/6/26 17:27, Caleb James DeLisle wrote:
> Hello, thanks for having a look.
>
>
> On 06/05/2026 16:39, Daniel Lezcano wrote:
>> On 4/16/26 19:51, Caleb James DeLisle wrote:
>>> This timer was first developed on the EN751221 which is a MIPS 34Kc
>>> and therefore has a custom interrupt controller. The hardware for
>>> econet,en751221-intc implements percpu routing of the timer
>>> interrupts.
>>>
>>> However, the EN751627 and EN7528 are MIPS 1004Kc based, and
>>> therefore use the standard mti,gic compatible interrupt controller.
>>> This interrupt controller uses a different IRQ number for each
>>> timer interrupt.
>>>
>>> Add support for both models in this timer driver.
>>
>> Given the changes done in this driver, the description is short and
>> does not explain why the code is so impacted.
>
>
> Fair enough. Supporting the two different IRQ models lead to an annoying
> amount of changes.
>
>
>>
>> I suggest to split the changes in order to facilitate the review process
>
>
> Okay, I'll see what I can do in this regard.
Perfect, thanks !
prev parent reply other threads:[~2026-05-06 15:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-16 17:50 [PATCH 0/2] clocksource/timer-econet-en751221: Support irq number per timer Caleb James DeLisle
2026-04-16 17:51 ` [PATCH 1/2] dt-bindings: timer: econet: Update EN751627 for multi-IRQ Caleb James DeLisle
2026-04-17 16:17 ` Conor Dooley
2026-04-16 17:51 ` [PATCH 2/2] clocksource/timer-econet-en751221: Support irq number per timer Caleb James DeLisle
2026-05-06 14:39 ` Daniel Lezcano
2026-05-06 15:27 ` Caleb James DeLisle
2026-05-06 15:39 ` Daniel Lezcano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89e792f3-3a8d-424f-abe4-b915bee63265@oss.qualcomm.com \
--to=daniel.lezcano@oss.qualcomm.com \
--cc=cjd@cjdns.fr \
--cc=conor+dt@kernel.org \
--cc=daniel.lezcano@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=naseefkm@gmail.com \
--cc=robh@kernel.org \
--cc=tglx@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.