From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wang, Haiyue Date: Sat, 27 Jul 2019 01:30:24 +0800 Subject: [RFC PATCH 15/17] ipmi: kcs: aspeed: Implement v2 bindings In-Reply-To: <20190726053959.2003-16-andrew@aj.id.au> References: <20190726053959.2003-1-andrew@aj.id.au> <20190726053959.2003-16-andrew@aj.id.au> Message-ID: <89ea7e21-944e-3d89-05b7-2dedb7916fa9@linux.intel.com> List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit ? 2019-07-26 13:39, Andrew Jeffery ??: > The v2 bindings allow us to extract the resources from the devicetree. > The table in the driver is retained to derive the channel index, which > removes the need for kcs_chan property from the v1 bindings. The v2 > bindings allow us to reduce the number of warnings generated by the > existing devicetree nodes. > > Cc: Haiyue Wang > Cc: Corey Minyard > Cc: Arnd Bergmann > Cc: Greg Kroah-Hartman > Cc:openipmi-developer at lists.sourceforge.net > Signed-off-by: Andrew Jeffery > --- > drivers/char/ipmi/kcs_bmc_aspeed.c | 156 +++++++++++++++++++++++------ > 1 file changed, 127 insertions(+), 29 deletions(-) Looks good, thanks for the hard work, the code is more clean! :) Reviewed-by: Haiyue Wang From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B147FC7618B for ; Fri, 26 Jul 2019 17:30:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8A6FB218DA for ; Fri, 26 Jul 2019 17:30:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ikVuag98" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8A6FB218DA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=eFRr8LTCH4UPbMz61DxbKi3jfgktguR1ZaJhfCRk0A4=; b=ikVuag98Ztr42H1gdI7yYRWln exz7+qTCTCP9T7mTI79NPXgGhg1Bt+81O2HkNYDjlY3tnTWwKkP7aDPL36BnlEydKO89DRqjb8ChE ul5nC8RHJMOXxY4ioGXjLoGR0vFJ+hIcwHzP0n8IsiBpJifln3xFkXWzCdOUkpnt/FV4dWcYFMMJ4 5u9hnGNSU8rG2lxIxVBijqLxB9zM3iSJZ/LPXA84JhRt/AWo53n3lKvvQSjpEYJTqDQEVmrpE7OyH xHuCrRDiX/Hp8LPmGx+Y5LGU08d5llD+hXm8YG2JsKAOUfzdku+ETUYioVC5Geo5NQtr/umZqdOll mDNHIgEhA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hr434-0006ie-VT; Fri, 26 Jul 2019 17:30:30 +0000 Received: from mga04.intel.com ([192.55.52.120]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hr431-0006hy-CG for linux-arm-kernel@lists.infradead.org; Fri, 26 Jul 2019 17:30:28 +0000 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Jul 2019 10:30:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,311,1559545200"; d="scan'208";a="369611738" Received: from haiyuewa-mobl.ccr.corp.intel.com (HELO [10.255.31.18]) ([10.255.31.18]) by fmsmga005.fm.intel.com with ESMTP; 26 Jul 2019 10:30:25 -0700 Subject: Re: [RFC PATCH 15/17] ipmi: kcs: aspeed: Implement v2 bindings To: Andrew Jeffery , linux-aspeed@lists.ozlabs.org References: <20190726053959.2003-1-andrew@aj.id.au> <20190726053959.2003-16-andrew@aj.id.au> From: "Wang, Haiyue" Message-ID: <89ea7e21-944e-3d89-05b7-2dedb7916fa9@linux.intel.com> Date: Sat, 27 Jul 2019 01:30:24 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190726053959.2003-16-andrew@aj.id.au> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190726_103027_428734_76D1F5F3 X-CRM114-Status: GOOD ( 11.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, Arnd Bergmann , Corey Minyard , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, robh+dt@kernel.org, joel@jms.id.au, openipmi-developer@lists.sourceforge.net, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="gbk"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org CtTaIDIwMTktMDctMjYgMTM6MzksIEFuZHJldyBKZWZmZXJ5INC0tcA6Cj4gVGhlIHYyIGJpbmRp bmdzIGFsbG93IHVzIHRvIGV4dHJhY3QgdGhlIHJlc291cmNlcyBmcm9tIHRoZSBkZXZpY2V0cmVl Lgo+IFRoZSB0YWJsZSBpbiB0aGUgZHJpdmVyIGlzIHJldGFpbmVkIHRvIGRlcml2ZSB0aGUgY2hh bm5lbCBpbmRleCwgd2hpY2gKPiByZW1vdmVzIHRoZSBuZWVkIGZvciBrY3NfY2hhbiBwcm9wZXJ0 eSBmcm9tIHRoZSB2MSBiaW5kaW5ncy4gVGhlIHYyCj4gYmluZGluZ3MgYWxsb3cgdXMgdG8gcmVk dWNlIHRoZSBudW1iZXIgb2Ygd2FybmluZ3MgZ2VuZXJhdGVkIGJ5IHRoZQo+IGV4aXN0aW5nIGRl dmljZXRyZWUgbm9kZXMuCj4KPiBDYzogSGFpeXVlIFdhbmc8aGFpeXVlLndhbmdAbGludXguaW50 ZWwuY29tPgo+IENjOiBDb3JleSBNaW55YXJkPG1pbnlhcmRAYWNtLm9yZz4KPiBDYzogQXJuZCBC ZXJnbWFubjxhcm5kQGFybmRiLmRlPgo+IENjOiBHcmVnIEtyb2FoLUhhcnRtYW48Z3JlZ2toQGxp bnV4Zm91bmRhdGlvbi5vcmc+Cj4gQ2M6b3BlbmlwbWktZGV2ZWxvcGVyQGxpc3RzLnNvdXJjZWZv cmdlLm5ldAo+IFNpZ25lZC1vZmYtYnk6IEFuZHJldyBKZWZmZXJ5PGFuZHJld0Bhai5pZC5hdT4K PiAtLS0KPiAgIGRyaXZlcnMvY2hhci9pcG1pL2tjc19ibWNfYXNwZWVkLmMgfCAxNTYgKysrKysr KysrKysrKysrKysrKysrKystLS0tLS0KPiAgIDEgZmlsZSBjaGFuZ2VkLCAxMjcgaW5zZXJ0aW9u cygrKSwgMjkgZGVsZXRpb25zKC0pCgpMb29rcyBnb29kLCB0aGFua3MgZm9yIHRoZSBoYXJkIHdv cmssIHRoZSBjb2RlIGlzIG1vcmUgY2xlYW4hIDopCgpSZXZpZXdlZC1ieTogSGFpeXVlIFdhbmcg PGhhaXl1ZS53YW5nQGxpbnV4LmludGVsLmNvbT4KCgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51 eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5v cmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Wang, Haiyue" Subject: Re: [RFC PATCH 15/17] ipmi: kcs: aspeed: Implement v2 bindings Date: Sat, 27 Jul 2019 01:30:24 +0800 Message-ID: <89ea7e21-944e-3d89-05b7-2dedb7916fa9@linux.intel.com> References: <20190726053959.2003-1-andrew@aj.id.au> <20190726053959.2003-16-andrew@aj.id.au> Mime-Version: 1.0 Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20190726053959.2003-16-andrew@aj.id.au> Sender: linux-kernel-owner@vger.kernel.org To: Andrew Jeffery , linux-aspeed@lists.ozlabs.org Cc: robh+dt@kernel.org, mark.rutland@arm.com, joel@jms.id.au, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Corey Minyard , Arnd Bergmann , Greg Kroah-Hartman , openipmi-developer@lists.sourceforge.net List-Id: devicetree@vger.kernel.org ÔÚ 2019-07-26 13:39, Andrew Jeffery дµÀ: > The v2 bindings allow us to extract the resources from the devicetree. > The table in the driver is retained to derive the channel index, which > removes the need for kcs_chan property from the v1 bindings. The v2 > bindings allow us to reduce the number of warnings generated by the > existing devicetree nodes. > > Cc: Haiyue Wang > Cc: Corey Minyard > Cc: Arnd Bergmann > Cc: Greg Kroah-Hartman > Cc:openipmi-developer@lists.sourceforge.net > Signed-off-by: Andrew Jeffery > --- > drivers/char/ipmi/kcs_bmc_aspeed.c | 156 +++++++++++++++++++++++------ > 1 file changed, 127 insertions(+), 29 deletions(-) Looks good, thanks for the hard work, the code is more clean! :) Reviewed-by: Haiyue Wang