From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 0/4] prevent stalls due to tiling changes and bo reuse Date: Fri, 23 Apr 2010 12:08:28 +0100 Message-ID: <89k304$ibaic8@orsmga001.jf.intel.com> References: <1271967172-3174-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from orsmga101.jf.intel.com (mga06.intel.com [134.134.136.21]) by gabe.freedesktop.org (Postfix) with ESMTP id DFD9D9E84C for ; Fri, 23 Apr 2010 04:08:47 -0700 (PDT) In-Reply-To: <1271967172-3174-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Eric Anholt Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, 22 Apr 2010 22:12:48 +0200, Daniel Vetter wrote: > Hi all, > > This patch-set prevents stalls due to bo reuse in libdrm. After having > tried to fix the set_tiling stall both in libdrm and the kernel, I think > fixing this in the kernel is the better option: This way gem nicely > abstracts away the execution semantics. The only place where the > asynchronous nature of the gpu leaks is in the busy ioctl, which userspace > should call to check whether a mmap of the bo would stall. > > Performance gains are minimal, but strictly positive (neglecting a 1% noise > level). cairo perf traces on my i945: > > old: without-patches > new: with-patches > Speedups > ======== > xlib-rgba firefox-planet-gnome-0 62418.67 (64895.61 1.98%) -> 57833.66 > (61105.65 2.92%): 1.08x speedup That's a little better than what I see here, but there is just about some improvements over the noise. The patches themselves look worthwhile cleanups. -ickle -- Chris Wilson, Intel Open Source Technology Centre