From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [ANNOUNCE] xf86-video-intel 2.11.901 Date: Tue, 15 Jun 2010 23:31:24 +0100 Message-ID: <89k77n$o2s296@fmsmga001.fm.intel.com> References: <87typ5qgbp.fsf@yoom.home.cworth.org> <201006151754.44532.anarsoul@gmail.com> <89kc63$h5vmfl@fmsmga002.fm.intel.com> <89kc63$h60g7r@fmsmga002.fm.intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1503519521==" Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 156179E878 for ; Tue, 15 Jun 2010 15:31:28 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Mime-version: 1.0 Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Clemens Eisserer , intel-gfx List-Id: intel-gfx@lists.freedesktop.org --===============1503519521== Content-Type: text/plain On Wed, 16 Jun 2010 00:05:34 +0200, Clemens Eisserer wrote: > Hi Chris, > > >  $ git checkout 2.11.901 > >  $ git revert f74b3f82 > Ah thanks, didn't know the checkout thing. > > Hmm, if I revert that commit it no longer builds: > CC i915_render.lo > i915_render.c: In function ‘i915_prepare_composite’: > i915_render.c:836: error: ‘intel_screen_private’ has no member named > ‘render_current_dest’ Argh. It has the vital half of the centre sampling fix mixed in. This hack should be sufficient to force the target buffer to be updated everytime. diff --git a/src/i915_render.c b/src/i915_render.c index 8870019..3505083 100644 --- a/src/i915_render.c +++ b/src/i915_render.c @@ -1435,7 +1435,7 @@ static void i915_emit_composite_setup(ScrnInfoPtr scrn) intel->last_3d = LAST_3D_RENDER; /* BUF_INFO is an implicit flush, so avoid if the target has not changed */ - if (dest != intel->render_current_dest) { + if (1 || dest != intel->render_current_dest) { uint32_t tiling_bits; tiling_bits = 0; That does indeed seem to have an effect on KDE -- can you confirm if it fixes the rendering corruption and if there remains any? Now to understand why. Thanks, -ickle -- Chris Wilson, Intel Open Source Technology Centre --===============1503519521== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1503519521==--