From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/agp/i915: trim stolen space to 32M Date: Thu, 08 Jul 2010 17:42:19 +0100 Message-ID: <89k77n$oab77c@fmsmga001.fm.intel.com> References: <20100708092246.66f81e97@virtuousgeek.org> <201007081737.10942.simon.farnsworth@onelan.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 309C19EBCD for ; Thu, 8 Jul 2010 09:42:23 -0700 (PDT) In-Reply-To: <201007081737.10942.simon.farnsworth@onelan.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Simon Farnsworth , intel-gfx@lists.freedesktop.org Cc: t.artem@mailcity.com List-Id: intel-gfx@lists.freedesktop.org On Thu, 8 Jul 2010 17:37:10 +0100, Simon Farnsworth wrote: > On Thursday 8 July 2010, Jesse Barnes wrote: > > Some BIOSes will claim a large chunk of stolen space. Unless we > > reclaim it, our aperture for remapping buffer objects will be > > constrained. So clamp the stolen space to 32M and ignore the rest. > > > > Fixes https://bugzilla.kernel.org/show_bug.cgi?id=15469 among others. > > > > Adding the ignored stolen memory back into the general pool using the > > memory hotplug code is left as an exercise for the reader. > > > > Signed-off-by: Jesse Barnes > > FWIW, given how simple the code actually is: > Reviewed-by: Simon Farnsworth Heh, you were meant to say: "What? Export a magic parameter from intel-gtt.c to indicate how much space to remove from the aperture guestimate, but not replace the *broken* code in i915_dma.c with an interface from intel-gtt.c to query and control the populated GTT more precisely?" ;-) -ickle -- Chris Wilson, Intel Open Source Technology Centre