From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: fix errata for sync flush enable on 845G/830M Date: Mon, 09 Aug 2010 18:04:50 +0100 Message-ID: <89k77n$ojogje@fmsmga001.fm.intel.com> References: <1281292780-28200-1-git-send-email-chris@chris-wilson.co.uk> <20100809094538.612f9f8a@virtuousgeek.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id C4DBD9E77C for ; Mon, 9 Aug 2010 10:05:08 -0700 (PDT) In-Reply-To: <20100809094538.612f9f8a@virtuousgeek.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, 9 Aug 2010 09:45:38 -0700, Jesse Barnes wrote: > Is this hack even needed? I noticed on my 945GM that INSTDONE has a > stuck bit when I use this code, removing it didn't seem to have any > negative effects... I'm not sure why we need to trigger a Sync on the GPU at this point, I just assumed it was one of those magic bits of code required to bring up the hardware. -- Chris Wilson, Intel Open Source Technology Centre