From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: Free hardware status page on unload when physically mapped Date: Thu, 07 Oct 2010 09:19:06 +0100 Message-ID: <89k77n$p5gseq@fmsmga001.fm.intel.com> References: <1286425487-22515-1-git-send-email-keithp@keithp.com> <1286430223.4928.5.camel@clockmaker-el6> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1286430223.4928.5.camel@clockmaker-el6> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Dave Airlie , Keith Packard Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Thu, 07 Oct 2010 15:43:43 +1000, Dave Airlie wrote: > On Wed, 2010-10-06 at 21:24 -0700, Keith Packard wrote: > > A physically mapped hardware status page is allocated at driver load > > time but was never freed. Call the existing code to free this page at > > driver unload time on hardware which uses this kind. > > the free_hws gets called after we disappear the mmio mapping for the > registers. it then writes a register after killing the hws, and oopses. Right, freeing the hws page is a definite oversight. It looks like we should only be doing so on the KMS-only path anyway which neatly pulls the call before the mmio teardown. Applied with the amendment to -next. -Chris -- Chris Wilson, Intel Open Source Technology Centre