From: Chris Wilson <chris@chris-wilson.co.uk>
To: Bryan Freed <bfreed@chromium.org>,
Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: intel-gfx@lists.freedesktop.org,
Olof Johansson <olofj@chromium.org>,
Mandeep Baines <msb@chromium.org>
Subject: Re: [PATCH] i915: Initialize panel timing registers if VBIOS did not.
Date: Fri, 08 Oct 2010 10:58:40 +0100 [thread overview]
Message-ID: <89k77n$p5t7tl@fmsmga001.fm.intel.com> (raw)
In-Reply-To: <AANLkTimODmDBdYBc=yZqcemRoauOan_Ag7cqRo_V18-Z@mail.gmail.com>
On Thu, 7 Oct 2010 17:05:46 -0700, Bryan Freed <bfreed@chromium.org> wrote:
> The time between start of the pixel clock and backlight enable is a basic
> panel timing constraint. If the Panel Power On/Off registers are found
> to be 0, assume we are booting without VBIOS initialization and set these
> registers to something reasonable.
That looks cleaner. Obviously my only concern is what happens if we ever
see a second device that posts without setting up the registers. We may as
well compile in the VBT for every single manufactured device... Or we
could add a ROM table the manufacturers must include that provides the
necessary register values for their hardware. There must be some
replacement for the BIOS, a device description table at least?
Does any one have a strong "this will damage my hardware" objection? Are
the values safe enough for *any* device?
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2010-10-08 9:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-08 0:05 [PATCH] i915: Initialize panel timing registers if VBIOS did not Bryan Freed
2010-10-08 9:58 ` Chris Wilson [this message]
2010-10-08 18:35 ` Bryan Freed
2010-10-08 20:11 ` Jim Gettys
2010-10-08 20:28 ` Chris Wilson
2010-10-08 21:17 ` Jesse Barnes
2010-10-13 21:00 ` Olof Johansson
2010-10-14 8:22 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='89k77n$p5t7tl@fmsmga001.fm.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=bfreed@chromium.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
--cc=msb@chromium.org \
--cc=olofj@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.