From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: Disable FDI link before retraining. Date: Mon, 09 Aug 2010 10:04:47 +0100 Message-ID: <89k83a$97blbt@azsmga001.ch.intel.com> References: <1280819532-2722-1-git-send-email-chris@chris-wilson.co.uk> <87ocdfmo7c.fsf@pollan.anholt.net> <8u3s8d$j7eqan@orsmga001.jf.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by gabe.freedesktop.org (Postfix) with ESMTP id E4D009E7C0 for ; Mon, 9 Aug 2010 02:04:50 -0700 (PDT) In-Reply-To: <8u3s8d$j7eqan@orsmga001.jf.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Eric Anholt , intel-gfx@lists.freedesktop.org Cc: Dave Airlie List-Id: intel-gfx@lists.freedesktop.org On Fri, 06 Aug 2010 22:57:33 +0100, Chris Wilson wrote: > On Fri, 06 Aug 2010 14:21:59 -0700, Eric Anholt wrote: > > With the drm fix to not re-dpms the crtc, is this one still needed? > > No. I had to disable both this and Dave Airlie's double dpms defense, but > with the drm crtc dpms fix this patch is no longer required. I was mistaken. I tried the wrong test case, in order to reproduce you have to change the fb size for which apparently userspace also does dpms-off/-on around the add fb. Not sure yet why this isn't caught and reduced to a no-op by drm-core. -- Chris Wilson, Intel Open Source Technology Centre