From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: intel_overlay_print_error_state() only needed for debugfs (v2) Date: Thu, 26 Aug 2010 11:02:39 +0100 Message-ID: <89k83a$9eiufk@azsmga001.ch.intel.com> References: <1282776152.3711.23.camel@mattotaupa> <1282780336-9271-1-git-send-email-tobias.doerffel@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by gabe.freedesktop.org (Postfix) with ESMTP id 71C8D9E985 for ; Thu, 26 Aug 2010 03:02:43 -0700 (PDT) In-Reply-To: <1282780336-9271-1-git-send-email-tobias.doerffel@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Tobias Doerffel , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, 26 Aug 2010 01:52:16 +0200, Tobias Doerffel wrote: > The function intel_overlay_print_error_state() is called from within > i915_error_state() in i915_debufs.c which is only built if > CONFIG_DEBUG_FS is set. When building without this option, seq_printf() > is not declared in intel_overlay.c and the file fails to compile. > Furthermore the whole function is superfluous in this case. Therefore > only build it if CONFIG_DEBUG_FS is set. > > Signed-off-by: Tobias Doerffel I've already posted a better patch to remove the compile warnings as well. The simple inclusion of seq_file.h is the best patch to go into mainline atm, with the more complete patch coming in via drm-intel-next. -- Chris Wilson, Intel Open Source Technology Centre