From: Chris Wilson <chris@chris-wilson.co.uk>
To: Pekka Enberg <penberg@kernel.org>, torvalds@linux-foundation.org
Cc: linux-kernel@vger.kernel.org, Pekka Enberg <penberg@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Sitsofe Wheeler <sitsofe@yahoo.com>,
Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH] Revert "drm/i915: fix vblank wait test condition"
Date: Sat, 04 Sep 2010 10:21:07 +0100 [thread overview]
Message-ID: <89k83a$9hv9li@azsmga001.ch.intel.com> (raw)
In-Reply-To: <1283588234-2514-1-git-send-email-penberg@kernel.org>
On Sat, 4 Sep 2010 11:17:14 +0300, Pekka Enberg <penberg@kernel.org> wrote:
> This reverts commit 9559fcdbff4f93d29af04478bbc48294519424f5. The commit causes
> wrong screen resolution on some i915 machines such as MacBook which is a
> regression from 2.6.35. The issue has been reported multiple times but no fix
> has emerged:
NAK. You can't simply hide one bug by introducing a much bigger one.
As you have an affected machine, find which wait_for_vblank() needs to be
replaced with a msleep(20|50).
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2010-09-04 9:21 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-04 8:17 [PATCH] Revert "drm/i915: fix vblank wait test condition" Pekka Enberg
2010-09-04 9:21 ` Chris Wilson [this message]
2010-09-04 16:29 ` Pekka Enberg
2010-09-04 19:54 ` Hugh Dickins
2010-09-04 20:42 ` Sven Joachim
2010-09-04 22:44 ` Sitsofe Wheeler
2010-09-05 7:58 ` Pekka Enberg
2010-09-05 9:37 ` Sitsofe Wheeler
2010-09-05 8:26 ` Fabio Comolli
2010-09-05 9:14 ` Sitsofe Wheeler
2010-09-05 10:13 ` Fabio Comolli
2010-09-05 10:21 ` Fabio Comolli
2010-09-05 12:27 ` Sitsofe Wheeler
2010-09-05 17:41 ` Fabio Comolli
2010-09-05 16:11 ` Pekka Enberg
2010-09-05 16:23 ` Chris Wilson
2010-09-05 16:40 ` Pekka Enberg
2010-09-05 17:21 ` Chris Wilson
2010-09-05 17:26 ` Pekka Enberg
2010-09-05 17:53 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='89k83a$9hv9li@azsmga001.ch.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=akpm@linux-foundation.org \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@kernel.org \
--cc=sitsofe@yahoo.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.