From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] allow 945 to control self refresh automatically Date: Fri, 08 Oct 2010 11:11:26 +0100 Message-ID: <89k83a$9u7opc@azsmga001.ch.intel.com> References: <1286235085-29700-1-git-send-email-lambchop468@gmail.com> <1286525134.3746.18.camel@pli1-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by gabe.freedesktop.org (Postfix) with ESMTP id E29B19E82F for ; Fri, 8 Oct 2010 03:11:30 -0700 (PDT) In-Reply-To: <1286525134.3746.18.camel@pli1-desktop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Li Peng , Alexander Lam Cc: intel-gfx@lists.freedesktop.org, peng.li@intel.com List-Id: intel-gfx@lists.freedesktop.org On Fri, 08 Oct 2010 16:05:34 +0800, Li Peng wrote: > Hi, Alexander: > > I think you are right that GEN3 hardware CXSR requires enabling low > power render writes. > > This patch is OK for me, but DRM_DEBUG_KMS is better than printk. Alexander, if you don't mind respinning your patch to fixup the bare printks and adding your signed-off-by and Li's ack, I'll apply this to next and give it some testing. Thanks, -Chris -- Chris Wilson, Intel Open Source Technology Centre