From: Chris Wilson <chris@chris-wilson.co.uk>
To: Dave Airlie <airlied@redhat.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: Use ENOENT consistently for the error return for an unmatched handle.
Date: Thu, 05 Aug 2010 09:25:32 +0100 [thread overview]
Message-ID: <89kc63$hlloja@fmsmga002.fm.intel.com> (raw)
In-Reply-To: <1280961991.3525.3.camel@clockmaker-el6>
On Thu, 05 Aug 2010 08:46:31 +1000, Dave Airlie <airlied@redhat.com> wrote:
> Have you verified no userspace relies on this return value? since this
> technically an ABI change.
>
> >From what I can see probably only libdrm tests care.
I haven't found any other instances of code checking return values, more
often the error code is simply reported. Even those tests show that we can
expect EINVAL, ENOENT or EBADF for an invalid buffer handle.
It's the reporting that I want clarified as the "invalid fd" is misleading
for bug reporters. (Doubly so when this gets confused with a genuine
EBADF!)
--
Chris Wilson, Intel Open Source Technology Centre
prev parent reply other threads:[~2010-08-05 8:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-04 13:19 [PATCH] drm: Use ENOENT consistently for the error return for an unmatched handle Chris Wilson
2010-08-04 22:46 ` Dave Airlie
2010-08-05 8:25 ` Chris Wilson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='89kc63$hlloja@fmsmga002.fm.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=airlied@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.