From: Chris Wilson <chris@chris-wilson.co.uk>
To: Adam Jackson <ajax@redhat.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915: Include a generation number in the device info
Date: Wed, 11 Aug 2010 15:29:30 +0100 [thread overview]
Message-ID: <89kc63$hng7pc@fmsmga002.fm.intel.com> (raw)
In-Reply-To: <1281536084.17843.3056.camel@atropine>
On Wed, 11 Aug 2010 10:14:44 -0400, Adam Jackson <ajax@redhat.com> wrote:
> On Wed, 2010-08-11 at 10:25 +0100, Chris Wilson wrote:
> > To simplify the IS_GEN[234] macros and to enable switching.
>
> I think your three cent titanium tax doesn't go too far enough.
>
> 830, 845g, 85x, and 865 all now have
>
> .gen = 2,
> .is_i8xx = 1,
>
> and nothing later has .is_i8xx, so that field can just go.
Yes. I was just worried about some subtle semantic difference between
is_i8xx and is_i9xx and the generation number. I still look at IS_I965G()
and shudder. So for the first patch, I wanted something obvious and simple
that gave me the ability to switch(INTEL_INFO(dev)->gen). I'd like to
replace some of the coarse is_i9xx with more fine-grained capability bits
that are more self-descriptive and clear when they can be relied upon.
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2010-08-11 14:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4C5E04F9.5010005@comcast.net>
2010-08-08 9:20 ` [PATCH] drm/i915: Fix offset page-flips on i965+ Chris Wilson
2010-08-08 11:39 ` Chris Wilson
2010-08-08 12:24 ` Daniel Vetter
2010-08-08 14:50 ` Daniel Vetter
2010-08-08 11:50 ` [PATCH] drm/i915: gen4 vs gen5 DISPLAY_FLIP discrepancy? Chris Wilson
2010-08-10 21:37 ` [PATCH] drm/i915: Fix offset page-flips on i965+ Jesse Barnes
2010-08-11 9:25 ` [PATCH 1/2] drm/i915: Include a generation number in the device info Chris Wilson
2010-08-11 14:14 ` Adam Jackson
2010-08-11 14:29 ` Chris Wilson [this message]
2010-08-11 9:25 ` [PATCH 2/2] drm/i915: Fix offset page-flips on i965+ Chris Wilson
2010-08-11 15:18 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='89kc63$hng7pc@fmsmga002.fm.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=ajax@redhat.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.