From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 2/2] drm/i915: Fix up address spaces in slow_kernel_write() Date: Fri, 28 May 2010 10:36:55 +0100 Message-ID: <89khjo$fhq87i@orsmga002.jf.intel.com> References: <1274966135-31667-1-git-send-email-chris@chris-wilson.co.uk> <1274966135-31667-2-git-send-email-chris@chris-wilson.co.uk> <20100528092849.GB3612@viiv.ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from orsmga101.jf.intel.com (mga06.intel.com [134.134.136.21]) by gabe.freedesktop.org (Postfix) with ESMTP id 8C8119E789 for ; Fri, 28 May 2010 02:37:12 -0700 (PDT) In-Reply-To: <20100528092849.GB3612@viiv.ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, 28 May 2010 11:28:50 +0200, Daniel Vetter wrote: > On Thu, May 27, 2010 at 02:15:35PM +0100, Chris Wilson wrote: > > Since we now get_user_pages() outside of the mutex prior to performing > > the copy, we kmap() the page inside the copy routine and so need to > > perform an ordinary memcpy() and not copy_from_user(). > > Patches look sane and will definitely help in (someday) fixing up the racy > pwrite/pread locking. Now who's being optimistic... ;-) All I am trying to do is find some way to explain https://bugs.freedesktop.org/show_bug.cgi?id=26645#c5 -ickle -- Chris Wilson, Intel Open Source Technology Centre