From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [PATCH] fix some intel_ring_begin size
Date: Sat, 12 Jun 2010 10:05:21 +0100
Message-ID: <89khjo$flr1bk@orsmga002.jf.intel.com>
References: <1276332326-5642-1-git-send-email-nanhai.zou@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
	by gabe.freedesktop.org (Postfix) with ESMTP id 444689E78F
	for <intel-gfx@lists.freedesktop.org>;
	Sat, 12 Jun 2010 02:05:25 -0700 (PDT)
In-Reply-To: <1276332326-5642-1-git-send-email-nanhai.zou@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Zou Nan hai <nanhai.zou@intel.com>, Eric Anholt <eric.anholt@intel.com>, intel-gfx <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Sat, 12 Jun 2010 16:45:26 +0800, Zou Nan hai <nanhai.zou@intel.com> wrote:
> Fix some intel_ring_begin size parameter.

Maybe we should pass dwords to intel_ring_begin()? Much easier for us poor
humans to count and make space for the number of following
intel_ring_emit() than it is for us to remember to convert it into
bytes...
-ickle

-- 
Chris Wilson, Intel Open Source Technology Centre