All of lore.kernel.org
 help / color / mirror / Atom feed
From: Giulio Benetti <giulio.benetti@benettiengineering.com>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Stefano Cottafavi <stefano.cottafavi@gmail.com>,
	Fabrice Fontaine <fontaine.fabrice@gmail.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 2/2] package/opencv4: BR2_PACKAGE_OPENCV4_LIB_OBJDETECT requires BR2_PACKAGE_OPENCV4_LIB_DNN
Date: Mon, 15 Aug 2022 14:45:38 +0200	[thread overview]
Message-ID: <8F776D99-F7CF-4239-B99B-2C9880F0FCAA@benettiengineering.com> (raw)
In-Reply-To: <20220815143538.19dbf4a4@windsurf>


> Il giorno 15 ago 2022, alle ore 14:35, Thomas Petazzoni <thomas.petazzoni@bootlin.com> ha scritto:
> 
> On Mon,  8 Aug 2022 00:25:29 +0200
> Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
> 
>> Opencv4 library objdetect needs library dnn, otherwise it throws:
>> ```
>> -- Module opencv_objdetect disabled because opencv_dnn dependency can't be resolved!
>> ```
>> So let's "select BR2_PACKAGE_OPENCV4_LIB_DNN" if
>> BR2_PACKAGE_OPENCV4_LIB_OBJDETECT is enabled.
>> 
>> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
>> ---
>> package/opencv4/Config.in | 1 +
>> 1 file changed, 1 insertion(+)
>> 
>> diff --git a/package/opencv4/Config.in b/package/opencv4/Config.in
>> index bdeddcc089..4991b4252b 100644
>> --- a/package/opencv4/Config.in
>> +++ b/package/opencv4/Config.in
>> @@ -155,6 +155,7 @@ config BR2_PACKAGE_OPENCV4_LIB_OBJDETECT
>>    select BR2_PACKAGE_OPENCV4_LIB_CALIB3D
>>    select BR2_PACKAGE_OPENCV4_LIB_IMGPROC
>>    select BR2_PACKAGE_OPENCV4_LIB_ML
>> +    select BR2_PACKAGE_OPENCV4_LIB_DNN
> 
> Alphabetic ordering was not correct, and it also lacked the propagation
> of the "depends on" of select BR2_PACKAGE_OPENCV4_LIB_DNN.

Oh no, again the dependencies in Config.in!
I still keep forgetting them :-/

> 
> The final patch is at:
> 
>  https://git.buildroot.org/buildroot/commit/?id=e229943785534e0884c62c7346a8c6df8d565e1e

Thank you Thomas, you’re too kind.

Best regards
Giulio

> 
> Best regards,
> 
> Thomas
> -- 
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-08-15 12:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-07 22:25 [Buildroot] [PATCH 0/2] Fix Opencv4 bug found by a user in Mailing list Giulio Benetti
2022-08-07 22:25 ` [Buildroot] [PATCH 1/2] package/opencv4: BR2_PACKAGE_OPENCV4_LIB_DNN requires protobuf Giulio Benetti
2022-08-15 12:35   ` Thomas Petazzoni via buildroot
2022-09-16 12:22   ` Peter Korsgaard
2022-08-07 22:25 ` [Buildroot] [PATCH 2/2] package/opencv4: BR2_PACKAGE_OPENCV4_LIB_OBJDETECT requires BR2_PACKAGE_OPENCV4_LIB_DNN Giulio Benetti
2022-08-15 12:35   ` Thomas Petazzoni via buildroot
2022-08-15 12:45     ` Giulio Benetti [this message]
2022-09-16 12:22   ` Peter Korsgaard
     [not found] ` <CAPn86JAWEZNtkMjdD-fMAyiiW1-vfmzM=79qV7wgmiy7XHbJ-A@mail.gmail.com>
2022-08-13 14:15   ` [Buildroot] [PATCH 0/2] Fix Opencv4 bug found by a user in Mailing list Giulio Benetti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8F776D99-F7CF-4239-B99B-2C9880F0FCAA@benettiengineering.com \
    --to=giulio.benetti@benettiengineering.com \
    --cc=buildroot@buildroot.org \
    --cc=fontaine.fabrice@gmail.com \
    --cc=stefano.cottafavi@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.