Re: [RFC] MIPS: fix generic zboot support

[Paul Cercueil <paul@crapouillou.net>]

Hi again,

Le lun., nov. 8 2021 at 09:54:38 +0000, Paul Cercueil 
<paul@crapouillou.net> a écrit :
> Hi,
> 
> Le ven., nov. 5 2021 at 09:52:32 -0400, YunQiang Su 
> <yunqiang.su@cipunited.com> a écrit :
>> There are 2 problems here:
>> 1. setting zload-y to 0xffffffff81000000 breaks booting on qemu -M 
>> \x7fboston.
>>    Why it is set here? Any other platform needs this value?
> 
> Is there another place where it should be set?
> 
> With this patch applied, kernels won't boot anymore on Ingenic boards.

Nevermind - it works, I just needed to adapt my tooling.

However, I think there should still be an option to have a fixed zload 
address, for the case where you want a vmlinuz.bin.

Cheers,
-Paul

>> 2. vmlinux.gz.itb should be appended to all-$(CONFIG_MIPS_GENERIC) 
>> \x7finstead
>>    of replacing. Otherwise, no vmlinuz will be built.
> 
> I build vmlinuz all the time, and never needed this patch.
> 
> Cheers,
> -Paul
> 
>> ---
>>  arch/mips/generic/Platform | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>> 
>> diff --git a/arch/mips/generic/Platform b/arch/mips/generic/Platform
>> index e1abc113b409..0c03623f3897 100644
>> --- a/arch/mips/generic/Platform
>> +++ b/arch/mips/generic/Platform
>> @@ -13,8 +13,7 @@ cflags-$(CONFIG_MACH_INGENIC_SOC)	+= 
>> \x7f-I$(srctree)/arch/mips/include/asm/mach-ing
>>  cflags-$(CONFIG_MIPS_GENERIC)	+= 
>> \x7f-I$(srctree)/arch/mips/include/asm/mach-generic
>> 
>>  load-$(CONFIG_MIPS_GENERIC)	+= 0xffffffff80100000
>> -zload-$(CONFIG_MIPS_GENERIC)	+= 0xffffffff81000000
>> -all-$(CONFIG_MIPS_GENERIC)	:= vmlinux.gz.itb
>> +all-$(CONFIG_MIPS_GENERIC)	+= vmlinux.gz.itb
>> 
>>  its-y					:= vmlinux.its.S
>>  its-$(CONFIG_FIT_IMAGE_FDT_BOSTON)	+= board-boston.its.S
>> --
>> 2.30.2
>> 
>