Re: New driver: s3d2xfb

[Richard Smith <smithbone@gmail.com>]

>>       if (!cnt) {
>>               save_s3(info);
>>       }

> You don't need to enclose a single statement with "curly braces".

I'm not trying to start any kind of flameage here but my curiosity was
just tweaked by that statement.

What do you like about single line if's over ones with {} that leads
you to advocate their usage?  You've obviously got loads of experience
with a large amount of code written by other people so I'm interested
in your opinion.

Feel free to take it off list if you think its too OT.

I deal with a lot of beginning programmers that go to the University
of Arkansas.  In many of the texts that I see now on introduction to
coding the emphasis is on rules that deal with consistency.  Not using
{} on every if block regardless of the size violates that rule.

I use linux in embedded systems and when I bring up linux on a new
system I sometimes have to pepper a driver with printks to see what's
not working right.

"one liners" are used in many places throughout the driver code and I
always end up going back and adding the {} so that I can add printks.

So IMHO "one liners" are an something of an annoyance. *grin*

--
Richard A. Smith


-------------------------------------------------------
This SF.Net email is sponsored by:
Power Architecture Resource Center: Free content, downloads, discussions,
and more. http://solutions.newsforge.com/ibmarch.tmpl