All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: "Haeuptle, Michael" <michael.haeuptle@hpe.com>,
	"io-uring@vger.kernel.org" <io-uring@vger.kernel.org>
Subject: Re: Bug? CQE.res = -EAGAIN with nvme multipath driver
Date: Fri, 10 Jan 2025 07:53:22 -0700	[thread overview]
Message-ID: <8a0eb82a-52b3-436c-85fe-86a6a1ebbf2b@kernel.dk> (raw)
In-Reply-To: <DS7PR84MB31106A2E2315A53CFA33B2B495132@DS7PR84MB3110.NAMPRD84.PROD.OUTLOOK.COM>

On 1/9/25 11:09 AM, Haeuptle, Michael wrote:
> Hey Jens, sorry for the late response.
> 
> I was unable to reproduce the issue with your branch. However, I
> didn't even hit the spot where same_thread_group check was removed.

Might be a driver side issue too on the nvme front, if it no longer hits
the retry path as much.

> We backported your changes to 6.1.119 and we did see that our original
> issue is fixed with your patches.
> 
> It seems to me that io_uring performance increased quite a bit in the
> latest kernel, judging from fio queue utilization of my workload.
> Maybe that's why I'm not hitting the place where same_thread_group was
> removed.

We do try and improve performance all the time, but most likely this is
caused by the same effect that reduces the reissue attempts as well.

> Your patch didn't cause any regression after 1d testing in my
> NVMF/RDMA & multipath setup. So, I think it would be good to get this
> patch on main.

Queued up, thanks for testing.

-- 
Jens Axboe

      reply	other threads:[~2025-01-10 14:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-06 20:03 Bug? CQE.res = -EAGAIN with nvme multipath driver Haeuptle, Michael
2025-01-06 23:53 ` Jens Axboe
2025-01-07  2:33   ` Jens Axboe
2025-01-07  2:39     ` Jens Axboe
2025-01-07 18:12       ` Jens Axboe
2025-01-07 18:24         ` Haeuptle, Michael
2025-01-07 18:26           ` Jens Axboe
2025-01-09 18:09             ` Haeuptle, Michael
2025-01-10 14:53               ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8a0eb82a-52b3-436c-85fe-86a6a1ebbf2b@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=io-uring@vger.kernel.org \
    --cc=michael.haeuptle@hpe.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.