From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 11/40] drm/i915/execlists: Onion unwind for logical_ring_init() failure Date: Thu, 20 Sep 2018 15:21:47 +0100 Message-ID: <8a161c2a-538d-2c7e-2882-0a20ac75f8e1@linux.intel.com> References: <20180919195544.1511-1-chris@chris-wilson.co.uk> <20180919195544.1511-11-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8090A6E5FE for ; Thu, 20 Sep 2018 14:21:56 +0000 (UTC) In-Reply-To: <20180919195544.1511-11-chris@chris-wilson.co.uk> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDE5LzA5LzIwMTggMjA6NTUsIENocmlzIFdpbHNvbiB3cm90ZToKPiBGaXggdXAgdGhlIGVy cm9yIHVud2luZCBmb3IgbG9naWNhbF9yaW5nX2luaXQoKSBmYWlsaW5nIGJ5IG1vdmluZyB0aGUK CkNvdWxkIHlvdSBzYXkgaW4gdGhlIGNvbW1pdCB3aGF0IHdhcyBicm9rZW4/CgpSZWdhcmRzLAoK VHZydGtvCgo+IGNsZWFudXAgaW50byB0aGUgY2FsbGVycyB3aG8gb3duIHRoZSB2YXJpb3VzIGJp dHMgb2Ygc3RhdGUgZHVyaW5nCj4gaW5pdGlhbGlzYXRpb24uCj4gCj4gU2lnbmVkLW9mZi1ieTog Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gLS0tCj4gICBkcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYyB8IDE4ICsrKysrKysrKysrLS0tLS0tLQo+ICAgMSBm aWxlIGNoYW5nZWQsIDExIGluc2VydGlvbnMoKyksIDcgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfbHJjLmMKPiBpbmRleCBiNDQ0OGIwNWQ3OGEuLjNlZGI0MTdjYWE3YiAxMDA2 NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYwo+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jCj4gQEAgLTI0MTUsNyArMjQxNSw3IEBAIHN0YXRp YyBpbnQgbG9naWNhbF9yaW5nX2luaXQoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+ ICAgCj4gICAJcmV0ID0gaW50ZWxfZW5naW5lX2luaXRfY29tbW9uKGVuZ2luZSk7Cj4gICAJaWYg KHJldCkKPiAtCQlnb3RvIGVycm9yOwo+ICsJCXJldHVybiByZXQ7Cj4gICAKPiAgIAlpZiAoSEFT X0xPR0lDQUxfUklOR19FTFNRKGk5MTUpKSB7Cj4gICAJCWV4ZWNsaXN0cy0+c3VibWl0X3JlZyA9 IGk5MTUtPnJlZ3MgKwo+IEBAIC0yNDU3LDEwICsyNDU3LDYgQEAgc3RhdGljIGludCBsb2dpY2Fs X3JpbmdfaW5pdChzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUpCj4gICAJcmVzZXRfY3Ni X3BvaW50ZXJzKGV4ZWNsaXN0cyk7Cj4gICAKPiAgIAlyZXR1cm4gMDsKPiAtCj4gLWVycm9yOgo+ IC0JaW50ZWxfbG9naWNhbF9yaW5nX2NsZWFudXAoZW5naW5lKTsKPiAtCXJldHVybiByZXQ7Cj4g ICB9Cj4gICAKPiAgIGludCBsb2dpY2FsX3JlbmRlcl9yaW5nX2luaXQoc3RydWN0IGludGVsX2Vu Z2luZV9jcyAqZW5naW5lKQo+IEBAIC0yNDgzLDEwICsyNDc5LDE0IEBAIGludCBsb2dpY2FsX3Jl bmRlcl9yaW5nX2luaXQoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+ICAgCWVuZ2lu ZS0+ZW1pdF9icmVhZGNydW1iID0gZ2VuOF9lbWl0X2JyZWFkY3J1bWJfcmNzOwo+ICAgCWVuZ2lu ZS0+ZW1pdF9icmVhZGNydW1iX3N6ID0gZ2VuOF9lbWl0X2JyZWFkY3J1bWJfcmNzX3N6Owo+ICAg Cj4gLQlyZXQgPSBpbnRlbF9lbmdpbmVfY3JlYXRlX3NjcmF0Y2goZW5naW5lLCBQQUdFX1NJWkUp Owo+ICsJcmV0ID0gbG9naWNhbF9yaW5nX2luaXQoZW5naW5lKTsKPiAgIAlpZiAocmV0KQo+ICAg CQlyZXR1cm4gcmV0Owo+ICAgCj4gKwlyZXQgPSBpbnRlbF9lbmdpbmVfY3JlYXRlX3NjcmF0Y2go ZW5naW5lLCBQQUdFX1NJWkUpOwo+ICsJaWYgKHJldCkKPiArCQlnb3RvIGVycl9jbGVhbnVwX2Nv bW1vbjsKPiArCj4gICAJcmV0ID0gaW50ZWxfaW5pdF93b3JrYXJvdW5kX2JiKGVuZ2luZSk7Cj4g ICAJaWYgKHJldCkgewo+ICAgCQkvKgo+IEBAIC0yNDk4LDcgKzI0OTgsMTEgQEAgaW50IGxvZ2lj YWxfcmVuZGVyX3JpbmdfaW5pdChzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUpCj4gICAJ CQkgIHJldCk7Cj4gICAJfQo+ICAgCj4gLQlyZXR1cm4gbG9naWNhbF9yaW5nX2luaXQoZW5naW5l KTsKPiArCXJldHVybiAwOwo+ICsKPiArZXJyX2NsZWFudXBfY29tbW9uOgo+ICsJaW50ZWxfZW5n aW5lX2NsZWFudXBfY29tbW9uKGVuZ2luZSk7Cj4gKwlyZXR1cm4gcmV0Owo+ICAgfQo+ICAgCj4g ICBpbnQgbG9naWNhbF94Y3NfcmluZ19pbml0KHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2lu ZSkKPiAKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50 ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==