Re: [PATCH 1/2] btrfs: tree-checker: introduce checks for FREE_SPACE_INFO

[Johannes Thumshirn <Johannes.Thumshirn@wdc.com>]

On 3/9/26 11:20 PM, Qu Wenruo wrote:
> Introduce checks for FREE_SPACE_INFO item, which include:
>
> - Key alignment check
>    The objectid is the logical bytenr of the chunk/bg, and offset is the
>    length of the chunk/bg, thus they should all be aligned to the fs
>    block size.
>
> - Item size check
>    The FREE_SPACE_INFO should a fix size.
                                       have ~^
>
> - Flags check
>    The flags member should has no other flags than

s/has/have/

[...]

> +static int check_free_space_info(struct extent_buffer *leaf, struct btrfs_key *key,
> +				 int slot)
> +{
> +	struct btrfs_fs_info *fs_info = leaf->fs_info;
> +	struct btrfs_free_space_info *fsi;
> +	const u32 blocksize = fs_info->sectorsize;
> +	u32 flags;
> +
> +	if (unlikely(!IS_ALIGNED(key->objectid, blocksize) ||
> +		     !IS_ALIGNED(key->offset, blocksize))) {
> +		generic_err(leaf, slot,
> +		"free space info key range is not aligned to %u, has (%llu %u %llu)",
> +			    blocksize, key->objectid, key->type, key->offset);
> +		return -EUCLEAN;
> +	}


I'd split that into two if()s, one for the objectid one for the offset. 
That'll help figuring out which of these two is unaligned without doing 
the math again on a possible bug report.

Thanks,

     Johannes