All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Christian König" <ckoenig.leichtzumerken@gmail.com>
To: Emily Deng <Emily.Deng@amd.com>, amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/amdgpu: Fix some unload driver issues
Date: Fri, 5 Mar 2021 10:53:12 +0100	[thread overview]
Message-ID: <8a33dfef-a761-9e5a-fd19-64045cfad657@gmail.com> (raw)
In-Reply-To: <20210305090429.452241-1-Emily.Deng@amd.com>

Am 05.03.21 um 10:04 schrieb Emily Deng:
> If have memory leak, maybe it will have issue in
> ttm_bo_force_list_clean-> ttm_mem_evict_first.
>
> Set adev->gart.ptr to null to avoid to call
> amdgpu_gmc_set_pte_pde to cause ptr issue pointer when
> calling amdgpu_gart_unbind in amdgpu_bo_fini which is after gart_fini.
>
> Signed-off-by: Emily Deng <Emily.Deng@amd.com>

Reviewed-by: Christian König <christian.koenig@amd.com>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_gart.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gart.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gart.c
> index 23823a57374f..f1ede4b43d07 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gart.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gart.c
> @@ -202,6 +202,7 @@ void amdgpu_gart_table_vram_free(struct amdgpu_device *adev)
>   		return;
>   	}
>   	amdgpu_bo_unref(&adev->gart.bo);
> +	adev->gart.ptr = NULL;
>   }
>   
>   /*

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

  reply	other threads:[~2021-03-05  9:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-05  9:04 [PATCH] drm/amdgpu: Fix some unload driver issues Emily Deng
2021-03-05  9:53 ` Christian König [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-03-05  1:20 Emily Deng
2021-03-05  7:54 ` Christian König
2021-03-05  8:43   ` Deng, Emily
2021-03-05  8:51     ` Christian König
2021-03-05  8:52       ` Deng, Emily

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8a33dfef-a761-9e5a-fd19-64045cfad657@gmail.com \
    --to=ckoenig.leichtzumerken@gmail.com \
    --cc=Emily.Deng@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.