From: Chuck Lever <chuck.lever@oracle.com>
To: Christoph Hellwig <hch@lst.de>, Dai Ngo <dai.ngo@oracle.com>
Cc: jlayton@kernel.org, neilb@ownmail.net, okorniev@redhat.com,
tom@talpey.com, alex.aring@gmail.com, viro@zeniv.linux.org.uk,
brauner@kernel.org, jack@suse.cz, linux-fsdevel@vger.kernel.org,
linux-nfs@vger.kernel.org
Subject: Re: [PATCH v4 1/3] locks: Introduce lm_breaker_timedout operation to lease_manager_operations
Date: Wed, 19 Nov 2025 09:04:19 -0500 [thread overview]
Message-ID: <8a55618d-ea6f-4fda-9be4-e1a76906d874@oracle.com> (raw)
In-Reply-To: <20251119095419.GB25764@lst.de>
On 11/19/25 4:54 AM, Christoph Hellwig wrote:
> On Sat, Nov 15, 2025 at 11:16:37AM -0800, Dai Ngo wrote:
>> Some consumers of the lease_manager_operations structure need
>> to perform additional actions when a lease break, triggered by
>> a conflict, times out.
>>
>> The NFS server is the first consumer of this operation.
>>
>> When a pNFS layout conflict occurs and the lease break times
>> out — resulting in the layout being revoked and its file lease
>> removed from the flc_lease list — the NFS server must issue a
>> fence operation. This operation ensures that the client is
>> prevented from accessing the data server after the layout
>> revocation.
>>
>> Fixes: f99d4fbdae67 ("nfsd: add SCSI layout support")
>
> This again does not fix anything. It is infrastructure for your fix
> in patch 3.
>
Dai -
I don't think the Fixes: is necessary. Please just fold this patch
into 3/3.
--
Chuck Lever
next prev parent reply other threads:[~2025-11-19 14:05 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-15 19:16 [Patch v4 0/3] NFSD: Fix server hang when there are multiple layout conflicts Dai Ngo
2025-11-15 19:16 ` [PATCH v4 1/3] locks: Introduce lm_breaker_timedout operation to lease_manager_operations Dai Ngo
2025-11-17 15:39 ` Chuck Lever
2025-11-17 19:17 ` Dai Ngo
2025-11-17 18:02 ` Jeff Layton
2025-11-17 19:41 ` Dai Ngo
2025-11-19 13:52 ` Jeff Layton
2025-11-19 16:32 ` Dai Ngo
2025-11-19 9:54 ` Christoph Hellwig
2025-11-19 14:04 ` Chuck Lever [this message]
2025-11-15 19:16 ` [PATCH v4 2/3] locks: Threads with layout conflict must wait until client was fenced Dai Ngo
2025-11-17 15:47 ` Chuck Lever
2025-11-17 19:21 ` Dai Ngo
2025-11-17 18:21 ` Jeff Layton
2025-11-17 19:49 ` Dai Ngo
2025-11-19 9:53 ` Christoph Hellwig
2025-11-15 19:16 ` [PATCH v4 3/3] FSD: Fix NFS server hang when there are multiple layout conflicts Dai Ngo
2025-11-15 19:44 ` Chuck Lever
2025-11-15 20:20 ` Dai Ngo
2025-11-19 9:56 ` Christoph Hellwig
2025-11-19 16:35 ` Dai Ngo
2025-11-17 15:55 ` Chuck Lever
2025-11-17 19:40 ` Dai Ngo
2025-11-17 21:13 ` Benjamin Coddington
2025-11-17 22:00 ` Dai Ngo
2025-11-19 10:08 ` Christoph Hellwig
2025-11-19 16:52 ` Dai Ngo
2025-11-20 6:50 ` Christoph Hellwig
2025-11-19 10:05 ` Christoph Hellwig
2025-11-19 14:04 ` Benjamin Coddington
2025-11-19 14:09 ` Chuck Lever
2025-11-19 14:12 ` Jeff Layton
2025-11-19 17:06 ` Dai Ngo
2025-11-20 6:52 ` Christoph Hellwig
2025-11-20 6:59 ` Christoph Hellwig
2025-11-19 9:57 ` Christoph Hellwig
2025-11-19 10:08 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a55618d-ea6f-4fda-9be4-e1a76906d874@oracle.com \
--to=chuck.lever@oracle.com \
--cc=alex.aring@gmail.com \
--cc=brauner@kernel.org \
--cc=dai.ngo@oracle.com \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@ownmail.net \
--cc=okorniev@redhat.com \
--cc=tom@talpey.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.